InterpreterStack::resumeGeneratorCallFrame should not call JSFunction::getOrCreateScript

RESOLVED FIXED in Firefox 63

Status

()

defect
--
trivial
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

10 months ago
InterpreterStack::resumeGeneratorCallFrame calls JSFunction::getOrCreateScript, but does not check whether the pointer returned is null.

It doesn't need to, because if you're resuming a generator, you know it isn't a lazy function. But that means that this function should use JSFunction::nonLazyScript instead.
Assignee

Comment 1

10 months ago
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #9001249 - Flags: review?(jorendorff)
Comment on attachment 9001249 [details] [diff] [review]
Make InterpreterStack::resumeGeneratorCallFrame not tolerate a lazy script.

Review of attachment 9001249 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks.
Attachment #9001249 - Flags: review?(jorendorff) → review+
Assignee

Updated

10 months ago
Keywords: checkin-needed

Comment 3

10 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d742e378449f
Make InterpreterStack::resumeGeneratorCallFrame not tolerate a lazy script. r=jorendorff
Keywords: checkin-needed

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d742e378449f
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.