148356 - contrib/cvs-update.sh should be in Perl

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Jouni Heikniemi]

cvs-update.sh should be rewritten in Perl to make it work on Win32 as well.

Comment 1

[Jouni Heikniemi]

Proposing 2.18 per roadmap's win32 statement.

Comment 2

[Zach Lipton [:zach]]

Part of the 'make upgrade' feature in newinstall. Not so sure about this in
2.18, my current 2.18 goal is to have newinstall do all that checksetup did, but
without too many new features.

Comment 3

[Dave Miller [:justdave]]

how about an additional script for Win32?  The existing script works too well on
Unix to have to make it slower.

Comment 4

[Jouni Heikniemi]

Is there a particular reason to think that converting such a trivial script 
into Perl would impose noticeable slowdown? Ok, you have to invoke perl, but I 
wouldn't think that has any significant effect when compared to the time cvs 
update takes to run anyway.

Comment 5

[J. Paul Reed [:preed]]

I'll chime in here... does cvs-update.sh NOT work with Cygwin?

Comment 6

[Jouni Heikniemi]

Possibly yes, but that's not really relevant (as requiring Cygwin is quite 
harsh)...

Comment 7

[Jouni Heikniemi]

Aw, gimme this stuff.

Zach, care to explain the dependency? A 2.20 bug blocking a 2.18 bug?

Comment 8

[Jouni Heikniemi]

Attachment: cvs-update.pl - take 1

Let's try this, hoping that the blocker mentioned above is just an old
newinstall plan and nothing relevant for this patch. ;-)

Comment 9

[Zach Lipton [:zach]]

Jouni: explained ;)

Comment 10

[Zach Lipton [:zach]]

Comment on attachment 134666 [details]
cvs-update.pl - take 1

>open LOG, ">>cvs-update.log" or die("Couldn't open cvs update log!");

The error message should include $@ to tell the user what went wrong. r=zach
with that change.

Comment 11

[Jouni Heikniemi]

I'll fix Zach's review comment and commit this after the weekend.

Comment 12

[Jouni Heikniemi]

re IRC discussion with Dave, also removing cvs-update.sh simultaneously.

Removing cvs-update.sh;
/cvsroot/mozilla/webtools/bugzilla/contrib/cvs-update.sh,v  <--  cvs-update.sh
new revision: delete; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/contrib/cvs-update.pl,v
done
Checking in cvs-update.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/cvs-update.pl,v  <--  cvs-update.pl
initial revision: 1.1
done