Closed Bug 1483570 Opened Last year Closed Last year

[wpt-sync] Sync PR 12503 - [css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12503 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12503
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set.
>  
>  In StyleValueToCSSValue, when checking whether a certain CSSStyleValue
>  matches the property in question, we now ask the registration (via
>  CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw
>  a TypeError like for normal properties. If it does match, the CSSStyleValue
>  is stringified, tokenized, and set on the style rule as tokens.
>  
>  I have postponed support for <color> and <transform-function>, because
>  CSSUnsupportedStyleValue currently does not handle registered custom
>  properties at all. This is appropriate to fix in a separate CL.
>  
>  Note that, because the string version of StylePropertyMap.set also uses
>  StyleValueToCSSValue, it will no longer be possible to set registered
>  custom properties with a string--even if the syntax is matched.
>  A subsequent CL will fix this.
>  
>  R=futhark@chromium.org
>  
>  Bug: 641877
>  Change-Id: Ie0cc2f87e39f8f59015824bfd1b81efaf402c326
>  Reviewed-on: https://chromium-review.googlesource.com/1175822
>  WPT-Export-Revision: 2e162cbffbed0b9e6a27809b039c5b390a6a4583
PR 12503 applied with additional changes from upstream: 816706b1fa03ffbc7b1f98a560f8ac7db80bc481
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 42 subtests
FAIL   : 42
ERROR  : 1

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-properties-values-api/typedom.tentative.html: ERROR

New tests that have failures or other problems:
/css/css-properties-values-api/typedom.tentative.html
    attributeStyleMap.get returns CSSImageValue for <image>: FAIL
    attributeStyleMap.get returns CSSKeywordValue for <custom-ident>: FAIL
    attributeStyleMap.get returns CSSKeywordValue for thing1 | THING2: FAIL
    attributeStyleMap.get returns CSSMathSum for <length-percentage> [calc(10px + 10%)]: FAIL
    attributeStyleMap.get returns CSSStyleValue for <color>: FAIL
    attributeStyleMap.get returns CSSStyleValue for <url>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <angle>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <integer>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length-percentage> [10%]: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length-percentage> [10px]: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length>#: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length>+: FAIL
    attributeStyleMap.get returns CSSUnitValue for <number>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <percentage>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <resolution>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <time>: FAIL
    attributeStyleMap.get returns CSSUnparsedValue for *: FAIL
    attributeStyleMap.get returns CSSUnparsedValue for value with var reference in list: FAIL
    attributeStyleMap.get returns CSSUnparsedValue for value with var references: FAIL
    attributeStyleMap.getAll returns a list of CSSUnitValues for <length>#: FAIL
    attributeStyleMap.getAll returns a list of CSSUnitValues for <length>+: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3166f55901c1
[wpt PR 12503] - [css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/d07641a80a1f
[wpt PR 12503] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/3166f55901c1
https://hg.mozilla.org/mozilla-central/rev/d07641a80a1f
Status: NEW → RESOLVED
Closed: Last year
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.