1483575 - Font editor: add line height controls

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Razvan Caliman [:rcaliman]]

Adds the ability to show and control the value of the `line-height` property in the Font Editor.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1483575 - (Part 1) Externalize units from FontPropertyValue component. r=gl

MozReview-Commit-ID: 65ObfBLlRR9

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1483575 - (Part 2) Add LineHeight component to font editor. r=gl

MozReview-Commit-ID: JiMBI3QMKML

Depends on D3498

Comment 3

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1483575 - (Part 3) Update unit conversion to handle unitless values. r=gl

Add special handling for line-height property.

Depends on D3498

Comment 4

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1483575 - (Part 4) Ensure computed value for line-height is converted to unitless. r=gl

Depends on D3500

Comment 5

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1483575 - Update font editor in response to font property value changes outside the selected rule. r=gl

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9001582 [details]
Bug 1483575 - Update font editor in response to font property value changes outside the selected rule. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9001577 [details]
Bug 1483575 - (Part 1) Externalize units from FontPropertyValue component. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9001578 [details]
Bug 1483575 - (Part 2) Add LineHeight component to font editor. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9001579 [details]
Bug 1483575 - (Part 3) Update unit conversion to handle unitless values. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9001581 [details]
Bug 1483575 - (Part 4) Ensure computed value for line-height is converted to unitless. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4bfcefc0535
(Part 1) Externalize units from FontPropertyValue component. r=gl

Comment 12

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=baef66d61a74642786557f5449665971d9f03cc4

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/961c73e8fac1
(Part 2) Add LineHeight component to font editor. r=gl

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c699458e1f
(Part 3) Update unit conversion to handle unitless values. r=gl

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acbbc15249bf
(Part 4) Ensure computed value for line-height is converted to unitless. r=gl

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e85a0366a599
Update font editor in response to font property value changes outside the selected rule. r=gl

Comment 17

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b4bfcefc0535
https://hg.mozilla.org/mozilla-central/rev/961c73e8fac1
https://hg.mozilla.org/mozilla-central/rev/26c699458e1f
https://hg.mozilla.org/mozilla-central/rev/acbbc15249bf
https://hg.mozilla.org/mozilla-central/rev/e85a0366a599