Closed Bug 1483638 Opened 6 years ago Closed 6 years ago

Update ical.js to the latest version

Categories

(Calendar :: ICAL.js Integration, enhancement)

Product:
Calendar
Component:
ICAL.js Integration
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: darktrojan)

References

Details

Attachments

(1 file, 1 obsolete file)

1483638-update-ical-2.diff
21.94 KB, patch
MakeMyDay
: review+
Details | Diff | Splinter Review 
We should update ical.js since the last update was in 2016 and upstream has some fixes that would us let close some bugs.

The upstream tip applies flawlessly for me and tests passed locally.
There are several commits that are not included in version 1.2.2 - Philipp, can you create a new version upstream?
Flags: needinfo?(philipp)
Blocks: 1179783
Attached patch 1483638-update-ical-1.diff (obsolete) — — Splinter Review 
This has been waiting long enough.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9016586 - Flags: review?(makemyday)
Comment on attachment 9016586 [details] [diff] [review]
1483638-update-ical-1.diff

Thanks for taking this, but the primary task here is for Philipp to tag a release in upstream (and maybe still merge suitable pending PR in upstream first) - I'd prefer not to downstream a non-release version (and the not yet downstreamed changes in 1.2.1 and 1.2.2 didn't comprise relevant changes for us).
Attachment #9016586 - Flags: review?(makemyday) → review-
Ok, I released 1.3.0 with what was on github. Let me know if anything is missing and I can do point releases a bit quicker this time.
Flags: needinfo?(philipp)
Attached patch 1483638-update-ical-2.diff — — Splinter Review 

        Attachment #9016586 -
        Attachment is obsolete: true

        Attachment #9024172 -
        Flags: review?(makemyday)

    
    

    
  
Comment on attachment 9024172 [details] [diff] [review]
1483638-update-ical-2.diff

Review of attachment 9024172 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r+

        Attachment #9024172 -
        Flags: review?(makemyday) → review+

    
    

    
  
Philipp, you should update your license block upstream, it still says 2011-2015. It would also be nice if PR 232 could be moved forward for the next update - it looks stalled.

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8869c51e0995
Update ical.js to the latest version. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

    
    

    
  
(In reply to [:MakeMyDay] from comment #0)
> The upstream tip applies flawlessly for me and tests passed locally.
I hope so.
Target Milestone: --- → 6.7

    
    

    
  
(In reply to [:MakeMyDay] from comment #0)
> ... has
> some fixes that would us let close some bugs.

Which ones?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: