Closed Bug 1483721 Opened Last year Closed Last year
Mime Type .cpp:176 and 283 "too big for character" MSVC (tier 2) error
46 bytes, text/x-phabricator-request
|Details | Review|
Bug 1454590 "Align overrideMIMEType with the XMLHttpRequest Standard" added a test file that doesn't compile in MSVC: https://treeherder.mozilla.org/logviewer.html#?job_id=194128196&repo=mozilla-central&lineNumber=20152 Looks like MSVC is now tier 2, so I guess that's why the patch was allowed in Central. However it would be great to get this fixed (or at least short-circuited) for the few of us still using MSVC at the moment.
MSVC is tier-2, so it's just a quick fix by disabling 2 of the many tests in TestMimeType.cpp.
Comment on attachment 9001462 [details] Bug 1483721 - Fix MSVC error by skipping tests with too-big characters - r?hsivonen Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9001462 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9c569226e852 Fix MSVC error by skipping tests with too-big characters - r=hsivonen
Thanks for the fix. I am stuck with this for a couple of hours.
You need to log in before you can comment on or make changes to this bug.