Closed Bug 1483721 Opened Last year Closed Last year

TestMimeType.cpp:176 and 283 "too big for character" MSVC (tier 2) error

Categories

(Core :: DOM: Core & HTML, defect)

63 Branch
x86_64
Windows 10
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

Bug 1454590 "Align overrideMIMEType with the XMLHttpRequest Standard" added a test file that doesn't compile in MSVC:
https://treeherder.mozilla.org/logviewer.html#?job_id=194128196&repo=mozilla-central&lineNumber=20152

Looks like MSVC is now tier 2, so I guess that's why the patch was allowed in Central. However it would be great to get this fixed (or at least short-circuited) for the few of us still using MSVC at the moment.
Assignee: nobody → gsquelart
MSVC is tier-2, so it's just a quick fix by disabling 2 of the many tests in
TestMimeType.cpp.
Comment on attachment 9001462 [details]
Bug 1483721 - Fix MSVC error by skipping tests with too-big characters - r?hsivonen

Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9001462 - Flags: review+
Blocks: 1483679
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c569226e852
Fix MSVC error by skipping tests with too-big characters - r=hsivonen
Thanks for the fix. I am stuck with this for a couple of hours.
https://hg.mozilla.org/mozilla-central/rev/9c569226e852
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.