Closed
Bug 1483738
Opened 3 years ago
Closed 3 years ago
Lazily load FormSubmitObserver code
Categories
(Firefox :: General, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(3 files)
This requires making the invalidformsubmit notifications... marginally more sane. They currently register things with the observer service which are not actually observers, and then having some other code iterate over registered observers and muck with them. For my purposes, I'd rather deal with a DOM event, but I'm also going to change the signature of these observers to be marginally more sane so that I have an easily accessible nsTArray to work with and continue to dispatch the "observer" callbacks as well, so I don't have to change Android code just now.
Assignee | ||
Comment 1•3 years ago
|
||
This makes things saner for all consumers, which makes it worth doing on its own. But it also gives me an easy nsTArray to work with, which I can use to dispatch DOM events with array properties.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Comment 4•3 years ago
|
||
Comment on attachment 9001471 [details] Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley Olli Pettay [:smaug] has approved the revision.
Attachment #9001471 -
Flags: review+
Comment on attachment 9001472 [details] Bug 1483738: Part 3 - Use lazy MozInvalidForm listener on desktop. r=mconley Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9001472 -
Flags: review+
Comment on attachment 9001471 [details] Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9001471 -
Flags: review+
Updated•3 years ago
|
Attachment #9001470 -
Attachment description: Bug 1483738: Part 1 - Change notifyInvalidSubmit to take a plain array. r?mconley → Bug 1483738: Part 1 - Change notifyInvalidSubmit to take a plain array. r=mconley
Updated•3 years ago
|
Attachment #9001471 -
Attachment description: Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r?smaug,mconley → Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley
Updated•3 years ago
|
Attachment #9001472 -
Attachment description: Bug 1483738: Part 3 - Use lazy MozInvalidForm listener on desktop. r?mconley → Bug 1483738: Part 3 - Use lazy MozInvalidForm listener on desktop. r=mconley
Assignee | ||
Comment 7•3 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f8bb8f44f2b612c964e1116282917e33168f989 Bug 1483738: Part 1 - Change notifyInvalidSubmit to take a plain array. r=mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/89c81ab0254376e6a7ae4a61fa2607d4ecd7b08b Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/9b5aefe66457f3bbb6403dbe7c149993c7c7eb70 Bug 1483738: Part 3 - Use lazy MozInvalidForm listener on desktop. r=mconley
Comment 8•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6f8bb8f44f2b https://hg.mozilla.org/mozilla-central/rev/89c81ab02543 https://hg.mozilla.org/mozilla-central/rev/9b5aefe66457
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•