Closed Bug 1483796 Opened Last year Closed Last year

[wpt-sync] Sync PR 12518 - Modify expected state for test of window.event with nodes moving

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12518 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12518
Details from upstream follow.

Yuki Yamada <yukiy@google.com> wrote:
>  Modify expected state for test of window.event with nodes moving
>  
>  WPT test for window.event checks global event with nodes moving.
>  Global event is set to invoked event before calling listener only if
>  global is a Window and tuple's item-in-shadow-tree is false.
>  (See 2-8: https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke)
>  This item-in-shadow-tree is saved before calling listener, so nodes
>  moving inside listener does not affect it.
>  (See 2: https://dom.spec.whatwg.org/#concept-event-path-append)
>  
>  Current test assumes that global event is set to invoked event even if
>  the EventTarget where the event is invoked at is in shadow tree before
>  calling listener, but it should not be set as mentioned above.
>  With this reason, window.event should be undefined if EventTarget is in
>  shadow tree. This CL correct it.
>  
>  Also, chromium does not support this operation now, so I created a
>  issue for this:
>  https://bugs.chromium.org/p/chromium/issues/detail?id=874770
>  
>  Change-Id: Ic068bcbde8fc2f128515be7c24f8829deb77d64a
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1177406
>  WPT-Export-Revision: 0805303fdcc757ff7c253bb46b15625d3f904947
Component: web-platform-tests → DOM
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 6 subtests
OK     : 1
PASS   : 5
FAIL   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c784b35d37a
[wpt PR 12518] - Modify expected state for test of window.event with nodes moving, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/462aee3a04b9
[wpt PR 12518] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/7c784b35d37a
https://hg.mozilla.org/mozilla-central/rev/462aee3a04b9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.