Closed Bug 1483880 Opened Last year Closed Last year

Autocompletion: enter key not properly handled

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: Honza, Assigned: nchevobbe)

Details

(Whiteboard: [boogaloo-mvp])

Attachments

(1 file)

STR:
1) Load any page (e.g. google.com)
2) Open the Toolbox and select the Console panel
3) The the following into the JSTerm: `document.location.host`
4) The autocompletion popup should be opened at this moment, offering `host` and `hostname` entries - where `host` is selected.
5) Pressing the Enter key doesn't close the popup -> BUG

Tested on Win10, Nightly build.

Honza
Whiteboard: [boogaloo-mvp]
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P1
When hitting enter, if there was no autocompletionText shown (because
the input was matching a proposed value), then the autocompletion
popup wasn't closed.
We now close it every time, and only check the completionText to
insert a possible string after the cursor.
A test case is added to make sure we don't regress this.
Comment on attachment 9002391 [details]
Bug 1483880 - Always hide the autocompletion popup in acceptProposedCompletion; r=Honza.

Jan Honza Odvarko [:Honza] has approved the revision.
Attachment #9002391 - Flags: review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28d5979962b7
Always hide the autocompletion popup in acceptProposedCompletion; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/28d5979962b7
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.