1483880 - Autocompletion: enter key not properly handled

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:
1) Load any page (e.g. google.com)
2) Open the Toolbox and select the Console panel
3) The the following into the JSTerm: `document.location.host`
4) The autocompletion popup should be opened at this moment, offering `host` and `hostname` entries - where `host` is selected.
5) Pressing the Enter key doesn't close the popup -> BUG

Tested on Win10, Nightly build.

Honza

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1483880 - Always hide the autocompletion popup in acceptProposedCompletion; r=Honza.

When hitting enter, if there was no autocompletionText shown (because
the input was matching a proposed value), then the autocompletion
popup wasn't closed.
We now close it every time, and only check the completionText to
insert a possible string after the cursor.
A test case is added to make sure we don't regress this.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

TRY is fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb806c4bff52b482f5807d82ad9694a9bdf9cd49

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9002391 [details]
Bug 1483880 - Always hide the autocompletion popup in acceptProposedCompletion; r=Honza.

Jan Honza Odvarko [:Honza] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28d5979962b7
Always hide the autocompletion popup in acceptProposedCompletion; r=Honza.

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/28d5979962b7