Closed
Bug 1483882
Opened 6 years ago
Closed 6 years ago
Shadow DOM: SVG url(#id) broken (gradient, clip-path)
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: sergio91pt, Assigned: emilio)
References
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Steps to reproduce: Attempted to use an svg inside a shadow root. The svg defines a gradient and uses it by referencing it with fill=url(#gradient_id). See atached test case. Actual results: A gradient defined in the same svg inside a shadow root cannot be used since url(#id) looks for the gradient outside the shadow root. Expected results: Since the svg is inside a shadow root, url(#id) should not be able to "break free" of the shadow dom and instead, should look for the node inside of the shadow root.
Reporter | ||
Updated•6 years ago
|
Component: Untriaged → DOM
Product: Firefox → Core
Updated•6 years ago
|
Component: DOM → SVG
Comment 1•6 years ago
|
||
So you expect Chrome's behavior, which is not what the spec says.
Comment 2•6 years ago
|
||
Related to https://github.com/w3c/webcomponents/issues/179
Assignee | ||
Comment 3•6 years ago
|
||
Looks like Safari does resolve fragids inside the shadow tree (except for <use>..). I can take this.
Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(emilio)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(emilio)
Assignee | ||
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9001702 [details]
Teach IDTracker about Shadow DOM.
Olli Pettay [:smaug] has approved the revision.
Attachment #9001702 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/d25d4da4aad2 Teach IDTracker about Shadow DOM. r=smaug
Comment 7•6 years ago
|
||
Backed out 1 changesets (Bug 1483882) for reftest failures in builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/fragid-shadow-3.html on a CLOSED TREE Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d25d4da4aad2c680854931bdde183f0e2f8948c7&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=194501089 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194501089&repo=autoland&lineNumber=12897 Backout: https://hg.mozilla.org/integration/autoland/rev/89c42a14642a3d11329d41702557b8b960603b22
Flags: needinfo?(emilio)
Assignee | ||
Comment 8•6 years ago
|
||
Gah, I always forget that CSS images don't block onload. Will fix the same way the other reftests deal with it: https://searchfox.org/mozilla-central/rev/246f2b4fab2c1a6cca99418bc2e4d73d1102cc38/layout/reftests/border-radius/corner-joins-2-ref.xhtml#33
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/4105f56578d4 Teach IDTracker about Shadow DOM. r=smaug
Comment 10•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/4656d3bf8e9c followup: Adjust a QR test expectation for now. r=me CLOSED TREE
Comment 11•6 years ago
|
||
Backed out 2 changesets (Bug 1483882) for reftest failures in uilds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/fragid-shadow-3.html Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4105f56578d414b83e302fe5f835824f1b6f3aac&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=194550537 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194550537&repo=autoland&lineNumber=12571 Backout: https://hg.mozilla.org/integration/autoland/rev/36e444c0d08452f6121c9c95a92a271ea7fe3858
Flags: needinfo?(emilio)
Comment 12•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/9c08d6d5d6f2 Teach IDTracker about Shadow DOM. r=smaug
Comment 14•6 years ago
|
||
Backed out for reftest failures on svg/fragid-shadow Backout link: https://hg.mozilla.org/integration/autoland/rev/d3430f59b182b466c0530966d193f8226f8c4de4 Push link: https://hg.mozilla.org/integration/autoland/rev/9c08d6d5d6f29b6bd44166cc1054d2f4b31c77d6 Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=194580334&repo=autoland&lineNumber=12355
Flags: needinfo?(emilio)
Assignee | ||
Comment 15•6 years ago
|
||
Will remove the text to work around bug 608812... Sigh.
Flags: needinfo?(emilio)
Assignee | ||
Comment 16•6 years ago
|
||
Looks green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cb4833cb04548a151eb0962d5048b381294bf04
Comment 17•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/3b7671939ef8 Teach IDTracker about Shadow DOM. r=smaug
Comment 18•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b7671939ef8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•