1483886 - Attachment icon and twisty are white on selected treeitems on Windows

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

This is also a fallout of bug 1469287: the attachment icon and the twisty on a selected treeitem are white instead black. This happens only on default themes.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: treeColors.patch

This fixes it. Mac needs no more the selected attachment icon. Set the attachment icon size is also no more needed.

Comment 2

[Jorg K (CEST = GMT+2)]

What's a default theme on Windows 10 and how do I enable it? I'm on W10 1803.

Comment 3

[Richard Marti (:Paenglab)]

You're on default theme. High Contrast or Classic on Win 7 are non-default themes.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9001614 [details] [diff] [review]
treeColors.patch

Another "find the problem first" review :-(

So the problem is that in the thread pane the paperclip icon is white instead of black. And in a threaded view, the twisty is also white. I can reproduce that. Richard told me via IRC.

The patch fixes that.

Comment 5

[Richard Marti (:Paenglab)]

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce2e22c9b8ab
Bug 1483332 follow-up: Make twisty and other tree icons use the correct selected color on Windows default themes. r=jorgk