Closed
Bug 1483913
Opened 6 years ago
Closed 5 years ago
prettifying comments in js/src/gdb/mozilla/unwind.py
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
Details
Attachments
(1 file)
Bug 1464869 made js/src/gdb/mozilla/unwind.py somewhat uglier, introducing two newlines between comments and the things they describe. For example: https://dxr.mozilla.org/mozilla-central/source/js/src/gdb/mozilla/unwind.py#532-537
|
Assignee | |
Comment 1•6 years ago
|
||
Hi Sylvestre. I'm wondering what I can do to make this more readable again. Thanks.
Flags: needinfo?(sledru)
|
||
Comment 2•6 years ago
|
||
My personal suggestion at least in that particular case is to actually use a doc string.
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → ttromey
Flags: needinfo?(sledru)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Bug 1464869 resulted in blank lines being inserted between comments and the classes they describe in the gdb unwinder code. This patch changes most of these comments into doc strings instead. MozReview-Commit-ID: 6XQwheUNRxI
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8a71e4402fc prettify gdb unwinder comments; r=nbp
|
|
Assignee | |
Comment 5•5 years ago
|
||
The tests aren't run in automation so I tried them out locally first.
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•