Closed Bug 1483913 Opened Last year Closed 11 months ago

prettifying comments in js/src/gdb/mozilla/unwind.py

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: tromey, Assigned: tromey)

Details

Attachments

(1 file)

Bug 1464869 made js/src/gdb/mozilla/unwind.py somewhat uglier,
introducing two newlines between comments and the things they 
describe.

For example:
https://dxr.mozilla.org/mozilla-central/source/js/src/gdb/mozilla/unwind.py#532-537
Hi Sylvestre.  I'm wondering what I can do to make this more readable again.
Thanks.
Flags: needinfo?(sledru)
My personal suggestion at least in that particular case is to actually use a doc string.
Assignee: nobody → ttromey
Flags: needinfo?(sledru)
Bug 1464869 resulted in blank lines being inserted between comments
and the classes they describe in the gdb unwinder code.  This patch
changes most of these comments into doc strings instead.

MozReview-Commit-ID: 6XQwheUNRxI
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8a71e4402fc
prettify gdb unwinder comments; r=nbp

The tests aren't run in automation so I tried them out locally first.

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.