1483933 - Searchfox gives 502 errors when searching

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

https://searchfox.org/mozilla-central/search?q=credited&redirect=false

Comment 1

[Andrew McCreight [:mccr8]]

This is possibly a dupe of bug 1483298. The searchfox indexing run is failing right now.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

You can use dev.searchfox.org in the meantime I think.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This was unrelated to bug 1483298. I thought I fixed it with mozsearch/mozsearch#130 but after looking at the logs again I think that was not the root cause. It looks like some queries might be getting tested as errors with the gRPC API that weren't with the JSON API previously. E.g.:

2018-08-16 05:30:51.711268/pid=19084 - QUERY line: "JSFlatString|Atom)", file: ".*", repo: "mozilla-central|mozilla-central-__GENERATED__", fold_case: true,
2018-08-16 05:30:51.712556/pid=19084 - Unable to start codesearch: <_Rendezvous of RPC that terminated with:                                        status = StatusCode.INVALID_ARGUMENT                                    details = "line: missing ): JSFlatString|Atom)"                         debug_error_string = "{"created":"@1534397451.712341950","description":"Error received from peer","file":"src/core/lib/surface/call.cc","file_line":1095,"grpc_message":"line: missing ): JSFlatString|Atom)","grpc_status":3}" 

And the error causes codeaearch.py to start another instance of the livegrep server. Maybe the query needs more escaping.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://github.com/mozsearch/mozsearch/pull/133

Comment 5

[Derek Reynolds [:Derek]]

Report on MOC channel from xidorn that all searchfox.org searches return a 502 error.  I directed him to dev.searchfox.org for now.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Thanks. I corrected the 502 error for now, will merge the above PR and rebuild to prevent it from reoccurring.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Fix for this is deployed now.