1483937 - Linux opt builds broken when Gecko 63 merges to Beta on 2018-08-27

Status: VERIFIED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1480631 switched most Linux builds to clang.

central as beta simulations have Linux opt (32 & 64 bit) failing today:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=587dd308797a67580077316ce6da6be6a9afbff9&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=194295995

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=194295995&repo=try

[task 2018-08-16T12:51:29.086Z] 12:51:29     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/modules/zlib/src'
[task 2018-08-16T12:51:29.087Z] 12:51:29     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang -std=gnu99 --target=i686-linux-gnu -o adler32.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -I/builds/worker/workspace/build/src/modules/zlib/src -I/builds/worker/workspace/build/src/obj-firefox/modules/zlib/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -O3 -fomit-frame-pointer -Werror -fprofile-instr-use=/builds/worker/workspace/build/src/obj-firefox/merged.profdata -Wno-error=profile-instr-out-of-date -Wno-error=profile-instr-unprofiled -MD -MP -MF .deps/adler32.o.pp   /builds/worker/workspace/build/src/modules/zlib/src/adler32.c
[task 2018-08-16T12:51:29.088Z] 12:51:29     INFO -  error: Could not read profile /builds/worker/workspace/build/src/obj-firefox/merged.profdata: No such file or directory
[task 2018-08-16T12:51:29.089Z] 12:51:29     INFO -  1 error generated.
[task 2018-08-16T12:51:29.089Z] 12:51:29     INFO -  /builds/worker/workspace/build/src/config/rules.mk:770: recipe for target 'adler32.o' failed
[task 2018-08-16T12:51:29.089Z] 12:51:29     INFO -  make[5]: *** [adler32.o] Error 1

Comment 1

[Mike Hommey [:glandium]]

So there are two problems here:
- That your push is using linux builds to do pgo. It seems beta does that too, that's an annoying difference. I can change the condition in build/unix/mozconfig.linux to check for MOZ_PGO as well.
- That your push is failing to do clang pgo, because it's supposed to work, actually.

Comment 2

[Mike Hommey [:glandium]]

Ah no, the second half is because of a part missing that I have in my patch queue for bug 1481721.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Still use GCC on MOZ_PGO builds that don't have FORCE_GCC

Yay for inconsistencies in jobs between beta and central.

Comment 4

[Mike Hommey [:glandium]]

Can you test this patch on a central-as-beta try?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Will do that in ~12 hours (have to check what patch stack is needed to actually compile betas after the last merges).

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thank you, the fix works: https://treeherder.mozilla.org/#/jobs?repo=try&revision=154722dd578a8e9b826292e708ef7448b6a5f373&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=194525661

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddb665c7fad0
Still use GCC on MOZ_PGO builds that don't have FORCE_GCC. r=froydnj

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ddb665c7fad0

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b26cee84b0d5507c1c08249bc8d26fa343a574fb&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

No need to track this for 63.