Closed Bug 1483957 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12531 - HTMLScriptElement text attribute modified to accept TrustedTypes

Categories

(Core :: DOM: Security, enhancement, P4)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog3]) 

Sync web-platform-tests PR 12531 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12531
Details from upstream follow.

Maja Kabus <kabusm@google.com> wrote:
>  HTMLScriptElement text attribute modified to accept TrustedTypes
>  
>  HTMLScriptElement::text() and setText() functions modified to accept
>  TrustedScript as an argument.
>  Old implementations abandoned.
>  
>  Requires change 1168494 to be merged first.
>  Tests need to be modified after change 1177752 is merged.
>  
>  Bug: 739170
>  Change-Id: I63da5714ffac328c6ae2f76e5da58c05f44a1cbf
>  Reviewed-on: https://chromium-review.googlesource.com/1178046
>  WPT-Export-Revision: 22f73b31c87fb539bfb95867d6e9c9c269420236
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream error][domsecurity-backlog3]
Whiteboard: [wptsync downstream error][domsecurity-backlog3] → [wptsync downstream][domsecurity-backlog3]
Whiteboard: [wptsync downstream][domsecurity-backlog3] → [wptsync downstream error][domsecurity-backlog3]
PR 12531 applied with additional changes from upstream: 313928249ac758939449d7d9f413af0bd6491e7e
Whiteboard: [wptsync downstream error][domsecurity-backlog3] → [wptsync downstream][domsecurity-backlog3]
Whiteboard: [wptsync downstream][domsecurity-backlog3] → [wptsync downstream error][domsecurity-backlog3]
Whiteboard: [wptsync downstream error][domsecurity-backlog3] → [wptsync downstream][domsecurity-backlog3]
PR 12531 applied with additional changes from upstream: 1de1550e95396f979da97620a289c213acaf55e2
PR 12531 applied with additional changes from upstream: 24373750793a107c28dbfde50d61cfae192fb485
Whiteboard: [wptsync downstream][domsecurity-backlog3] → [wptsync downstream error][domsecurity-backlog3]
Whiteboard: [wptsync downstream error][domsecurity-backlog3] → [wptsync downstream][domsecurity-backlog3]
Ran 2 tests and 37 subtests
OK     : 1
FAIL   : 37
ERROR  : 1

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html: ERROR

New tests that have failures or other problems:
/trusted-types/HTMLElement-generic.tentative.html
    script.innerText assigned via policy (successful Script transformation): FAIL
    script.text assigned via policy (successful Script transformation): FAIL
    script.textContent assigned via policy (successful Script transformation): FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e784605e8292
[wpt PR 12531] - HTMLScriptElement text attributes modified to accept TrustedTypes, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d6a923fbd8c
[wpt PR 12531] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/e784605e8292
https://hg.mozilla.org/mozilla-central/rev/1d6a923fbd8c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.