Closed Bug 1483964 Opened 5 years ago Closed 5 years ago

Manually inline class and ID getters for rust.

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

Unify InternalAttr and ServoAttrSnapshot.
46 bytes, text/x-phabricator-request
smaug
: review+
xidorn
: review+
Details | Review
Manually inline class and ID getters.
46 bytes, text/x-phabricator-request
xidorn
: review+
Details | Review 
This speeds up bug 1422522 considerably, from 1800ms to 1450ms on my machine. It also improves bug 1468739.

We can do this without duplicating too much magic from AttrArray after bug 1482866.
They're the same, and they aren't complex enough to be an AttrArray
implementation detail I think.
Somewhat ugly but hopefully not too much.

Somehow it ends up removing more lines than adding.
Comment on attachment 9001713 [details]
Unify InternalAttr and ServoAttrSnapshot.

Olli Pettay [:smaug] has approved the revision.
Attachment #9001713 - Flags: review+
Comment on attachment 9001713 [details]
Unify InternalAttr and ServoAttrSnapshot.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9001713 - Flags: review+
Comment on attachment 9001714 [details]
Manually inline class and ID getters.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9001714 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7a2da45f8f7
Unify InternalAttr and ServoAttrSnapshot. r=smaug,xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/62d4efbe32d7
Manually inline class and ID getters. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/a7a2da45f8f7
https://hg.mozilla.org/mozilla-central/rev/62d4efbe32d7
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.