1483979 - Enable FxA commands and let it ride the trains

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Edouard Oger [:eoger]]

Aiming for Firefox 63 (so this has to merge before August 23).

Note for myself: Do not forget to bump the device registration version to upgrade existing clients.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1483979 - Enable fxa commands

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 9001811 [details]
Bug 1483979 - Enable fxa commands

Mark Hammond [:markh] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033428417ae7
Enable fxa commands r=markh

Comment 4

[Eliza Balazs [:ebalazs_]]

Backed out changeset 033428417ae7 (Bug 1483979) for bc failures in browser/components/customizableui/test/browser_remote_tabs_button.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=033428417ae747ed46fc9974409cec655b96956d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=194476050

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194475736&repo=autoland&lineNumber=10094

Backout push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d2ba1d6c76f28d6285004c8bf2d213a46ea23d46&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f973f3bf41a
Enable fxa commands r=markh

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8f973f3bf41a

Comment 7

[Hector Zhao [:hectorz]]

(In reply to Edouard Oger [:eoger] from comment #0)
> 
> Note for myself: Do not forget to bump the device registration version to
> upgrade existing clients.

This is not bumped in the patch, is it intentional?

Comment 8

[Edouard Oger [:eoger]]

Sorry I should have reflected that in a comment:

We don't need to bump the device registration version as we compare the set of commands we *should have* registered (availableCommandsKeys) and the set of commands we registered in the past (registeredCommandsKeys) before making a decision to re-register our device record. [0]

Flipping that feature pref is enough to change the set of commands we *should* register, therefore everyone re-registered their device.

[0] https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/services/fxaccounts/FxAccounts.jsm#719-724

Comment 9

[Hector Zhao [:hectorz]]

(In reply to Edouard Oger [:eoger] from comment #8)
> Sorry I should have reflected that in a comment:
> 
> We don't need to bump the device registration version as we compare the set
> of commands we *should have* registered (availableCommandsKeys) and the set
> of commands we registered in the past (registeredCommandsKeys) before making
> a decision to re-register our device record. [0]
> 
> Flipping that feature pref is enough to change the set of commands we
> *should* register, therefore everyone re-registered their device.
> 
> [0]
> https://searchfox.org/mozilla-central/rev/
> e0c879c86b95bdc752b1dbff6088169735674e4a/services/fxaccounts/FxAccounts.
> jsm#719-724

Thanks for the explanation