Closed Bug 1483979 Opened Last year Closed Last year

Enable FxA commands and let it ride the trains

Categories

(Firefox :: Sync, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: eoger, Assigned: eoger)

References

Details

Attachments

(1 file)

Aiming for Firefox 63 (so this has to merge before August 23).

Note for myself: Do not forget to bump the device registration version to upgrade existing clients.
Comment on attachment 9001811 [details]
Bug 1483979 - Enable fxa commands

Mark Hammond [:markh] has approved the revision.
Attachment #9001811 - Flags: review+
Flags: needinfo?(eoger)
https://hg.mozilla.org/mozilla-central/rev/8f973f3bf41a
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
(In reply to Edouard Oger [:eoger] from comment #0)
> 
> Note for myself: Do not forget to bump the device registration version to
> upgrade existing clients.

This is not bumped in the patch, is it intentional?
Sorry I should have reflected that in a comment:

We don't need to bump the device registration version as we compare the set of commands we *should have* registered (availableCommandsKeys) and the set of commands we registered in the past (registeredCommandsKeys) before making a decision to re-register our device record. [0]

Flipping that feature pref is enough to change the set of commands we *should* register, therefore everyone re-registered their device.

[0] https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/services/fxaccounts/FxAccounts.jsm#719-724
(In reply to Edouard Oger [:eoger] from comment #8)
> Sorry I should have reflected that in a comment:
> 
> We don't need to bump the device registration version as we compare the set
> of commands we *should have* registered (availableCommandsKeys) and the set
> of commands we registered in the past (registeredCommandsKeys) before making
> a decision to re-register our device record. [0]
> 
> Flipping that feature pref is enough to change the set of commands we
> *should* register, therefore everyone re-registered their device.
> 
> [0]
> https://searchfox.org/mozilla-central/rev/
> e0c879c86b95bdc752b1dbff6088169735674e4a/services/fxaccounts/FxAccounts.
> jsm#719-724

Thanks for the explanation
You need to log in before you can comment on or make changes to this bug.