Closed Bug 1483994 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 12535 - Revert "Cache Storage: Check for duplicate entries in Cache.addAll()."

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12535 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12535
Details from upstream follow.

Ben Kelly <wanderview@chromium.org> wrote:
>  Revert "Cache Storage: Check for duplicate entries in Cache.addAll()."
>  
>  This reverts commit 74fd352e51322e823070088c7d5c72e911966580.
>  
>  Reason for revert: Moving behind experimental feature flag until web compat can be assessed.
>  
>  Original change's description:
>  > Cache Storage: Check for duplicate entries in Cache.addAll().
>  > 
>  > This implements step 4.2.3 of the BatchCacheOperations algorithm:
>  > 
>  > https://w3c.github.io/ServiceWorker/#batch-cache-operations-algorithm
>  > 
>  > Bug: 720919
>  > Change-Id: I679f786441b813ed816a183522021c417f4ab7b8
>  > Reviewed-on: https://chromium-review.googlesource.com/1162362
>  > Commit-Queue: Ben Kelly <wanderview@chromium.org>
>  > Reviewed-by: Joshua Bell <jsbell@chromium.org>
>  > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
>  > Reviewed-by: Victor Costan <pwnall@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#582738}
>  
>  TBR=jsbell@chromium.org,kinuko@chromium.org,pwnall@chromium.org,wanderview@chromium.org
>  
>  # Not skipping CQ checks because original CL landed > 1 day ago.
>  
>  Bug: 720919
>  Change-Id: I08736e4ec638a65c48f329966f378698a6d9b045
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1178502
>  WPT-Export-Revision: d1cf66ea5894eb3ec49547077580e430d3dc3dcb
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 55 subtests
OK     : 3
PASS   : 52
FAIL   : 3
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8490f20070e
[wpt PR 12535] - Revert "Cache Storage: Check for duplicate entries in Cache.addAll().", a=testonly
https://hg.mozilla.org/mozilla-central/rev/a8490f20070e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.