Closed Bug 1483997 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12536 - Revert "[css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set."

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12536 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12536
Details from upstream follow.

Xida Chen <xidachen@chromium.org> wrote:
>  Revert "[css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set."
>  
>  This reverts commit b786c57cab4e93f6736fecfcc986c36dfbddd507.
>  
>  Reason for revert: <INSERT REASONING HERE>
>  layout test failed:
>  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/15210
>  
>  Original change's description:
>  > [css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set.
>  > 
>  > In StyleValueToCSSValue, when checking whether a certain CSSStyleValue
>  > matches the property in question, we now ask the registration (via
>  > CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw
>  > a TypeError like for normal properties. If it does match, the CSSStyleValue
>  > is stringified, tokenized, and set on the style rule as tokens.
>  > 
>  > I have postponed support for <color> and <transform-function>, because
>  > CSSUnsupportedStyleValue currently does not handle registered custom
>  > properties at all. This is appropriate to fix in a separate CL.
>  > 
>  > Note that, because the string version of StylePropertyMap.set also uses
>  > StyleValueToCSSValue, it will no longer be possible to set registered
>  > custom properties with a string--even if the syntax is matched.
>  > A subsequent CL will fix this.
>  > 
>  > R=​futhark@chromium.org
>  > 
>  > Bug: 641877
>  > Change-Id: Ie0cc2f87e39f8f59015824bfd1b81efaf402c326
>  > Reviewed-on: https://chromium-review.googlesource.com/1175822
>  > Commit-Queue: Anders Ruud <andruud@chromium.org>
>  > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#583695}
>  
>  TBR=futhark@chromium.org,andruud@chromium.org
>  
>  Change-Id: I2486be60ce81497253bdf64903ea870832a0ef9e
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 641877
>  Reviewed-on: https://chromium-review.googlesource.com/1178503
>  Reviewed-by: Xida Chen <xidachen@chromium.org>
>  Commit-Queue: Xida Chen <xidachen@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#583747}
>
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 42 subtests
OK     : 1
FAIL   : 42
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d267941739e0
[wpt PR 12536] - Revert "[css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set.", a=testonly
https://hg.mozilla.org/mozilla-central/rev/d267941739e0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.