Running testing under dom/tests/mochitest/dom-level2-core/ leak if shadow DOM is enabled in testing profile

RESOLVED FIXED in Firefox 63

Status

()

defect
P2
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

10 months ago
It is enough to have just the following in mochitest.ini to see the leak.
If nsContentUtils::IsShadowDOMEnabled() check in XMLPrettyPrinter is disabled, there is no leak.


[DEFAULT]
support-files =
  DOMTestCase.js
  exclusions.js
  files/hc_staff.html
  files/hc_staff.svg
  files/hc_staff.xhtml
  files/hc_staff.xml
  files/internalSubset01.js
  files/nodtdstaff.svg
  files/nodtdstaff.xml
  files/staff.dtd
  files/staff.svg
  files/staff.xml
  files/staff2.dtd
  files/staff2.svg
  files/staff2.xml
  files/staffNS.dtd
  files/staffNS.svg
  files/staffNS.xml
  files/svgtest.js
  files/svgunit.js
  files/xhtml-lat1.ent
  files/xhtml-special.ent
  files/xhtml-symbol.ent
  files/xhtml1-frameset.dtd
  files/xhtml1-strict.dtd
  files/xhtml1-transitional.dtd

[test_setNamedItemNS02.html]
[test_setNamedItemNS03.html]
Assignee

Comment 1

10 months ago
And when we leak, we leak the world.
Assignee

Updated

10 months ago
Assignee: nobody → bugs
Assignee

Comment 2

10 months ago
Better to actually unbind the child elements of shadow root properly.

See similar code at the end of Element::UnbindFromTree
Attachment #9001787 - Flags: review?(timdream)
Attachment #9001787 - Flags: review?(timdream) → review+

Comment 3

10 months ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17adf3f924cc
unbind shadow DOM content when uninstalling shadow DOM based XML Pretty Printer, r=timdream
Assignee

Updated

10 months ago
Blocks: 1471947
Priority: -- → P2

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/17adf3f924cc
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.