1484057 - Send tab not working after password change

Status: NEW

(Firefox for iOS :: Sync, defect, P3)

Description

[Kanchan Kumari QA]

Attachment: Device list.docx

STR:
1. Sign in to multiple device with newly created Fx account(two desktops, iOS, Android), the latest nightly for Android and Desktops, Latest beta for iOS
2. Sync all device, devices are matching fine in send tab device list on all devices
3. On Desktops change identity.fxaccounts.commands.enabled;true
4. Restart browser on desktops
 Device list differs from send tab list. Please see attached image
5. Send tab from desktop to Desktop and Android
 Browser console shows expected messages
Sending a tab to test2 using FxA commands. browser-sync.js:344:7
Sending a tab to Nightly on D6503 using Sync. (Android device) 

Observed: Tab is not received on Android

Send tab from Android is working fine.

iOS device is out of Sync here

Comment 1

[Edouard Oger [:eoger]]

Justin looks like the iOS device list was out of date?

Comment 2

[Justin D'Arcangelo [:justindarc]]

I don't see any mention of iOS here? The screenshots shown are not from iOS, they're from desktop. I also don't see any iOS devices listed in the screenshots?

Comment 3

[Kanchan Kumari QA]

On today's Nightly, I am seeing this issue with Android device. On Desktop or iOS devices, Android device doesn't appear in send tab device list, whereas FxA device list shows Android as connected. 

In devices and Apps section on FxA page on Desktop and iOS, last synced time for Android is not updating. Even though Android is synced <1 min ago,  it shows wrong time (>20 minutes ago). On Android, last synced time appears correct for other synced devices. Seems here sync is happening one way only.  

Sending tab from Android to other devices is working fine.

Comment 4

[Kanchan Kumari QA]

Somehow Last synced time is matching up on all devices but Android still doesn't appear in send tab device list.

Comment 5

[Edouard Oger [:eoger]]

Investigating the issue

Comment 6

[Edouard Oger [:eoger]]

Kanchan could you send the clients collection contents and the FxA device list (both of them are available in about:sync)?
I'm thinking Firefox for Android might have trouble registering its own client record (although that seems unlikely).

Comment 7

[Kanchan Kumari QA]

(In reply to Edouard Oger [:eoger] from comment #6)
> Kanchan could you send the clients collection contents and the FxA device
> list (both of them are available in about:sync)?
> I'm thinking Firefox for Android might have trouble registering its own
> client record (although that seems unlikely).

You meant about:sync-log? 

I couldn't reproduce this issue today. I will attach the log once I do. While trying to duplicate this I observed bug 1496258.

Comment 8

[Edouard Oger [:eoger]]

Sorry I meant from the about:sync addon.

Comment 9

[Kanchan Kumari QA]

Attachment: logs.7z

I was able to reproduce this bug today. After password reset on ipad and signing back to other three devices (iPhone, Android and desktop) with new password. Now about:sync, FxA setting page and send tab shows different device list. Please see video below

https://svtest2222-gmail.tinytake.com/sf/Mjk3MjM5MF84OTE1Nzk1

I made sure iPhone is connected (signed in with new password). FxA device list and send device list is out of sync on all devices.

1. iPhone doesn't appear on Android send tab list but appears under FxA device list. 
2. Tab is getting send from iOS to Android  and received on Android notification after manual sync on android phone. 
3. iPhone appears in FxA device list on all other three devices but not in send tab list on android and iPad.  
4. iPhone send tab device list does not show iPad vice versa iPad doesn't show iPhone in send tab device list
5. iphone is not sending/receiving tab from desktop though they appear under each other's send tab list. Desktop shows wrong last sync time for iPhone.


I am attaching sync logs too in case it's useful to you.

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Ed, can you please take a look?

Comment 11

[Edouard Oger [:eoger]]

Kanchan, would it be possible to get:
- A detailed description of the devices/versions of Firefox involved.
- A copy paste of the content of client -> "Records (object)" and client -> "FxA devices" from about:sync.
- A step by step description on how to reproduce the problem from a brand new FxA account.

Thanks!

Comment 12

[Kanchan Kumari QA]

Prerequisite: About:sync addon is installed on new Fx profile

STR: 
1. Sign in to sync on Win 10 desktop with new sync account and new Fx profile
   Version 	64.0a1
   Build ID 	20181010100123
   User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
2. Sign in to sync on Android mobile
   Nexus 5
   Android version  5.1.1
   Firefox Version  64.0a1 (2018-10-10)
3. Sign in to sync on iPad Air 2
   iOS 12.0.1
   Firefox Beta 
   Version 14.o(12307)
3. Sign in to sync on iPhone 7
   iOS 12.0.1
   Firefox Beta 
   Version 14.o(12307)
4. Verify send/receive tabs from all device working fine (other than known bug 1484059). 
5. Verify FxA device list, about:sync client collection and send tab list are showing all devices as expected.
   Observed: No issue so far.
6. Change FxA password on iPad
7. All other three devices are disconnected from sync.
8. Sign back to sync on desktop, iPhone and Android with new password

Observed following in browse console:
---------------------------------------

Could not find associated FxA device for Firefox Beta on Softvision’s iPhone browser-sync.js:332:9
Could not find associated FxA device for Nightly on Nexus 5 browser-sync.js:332:9
Sending a tab to Firefox Beta on Softvision’s iPad using FxA commands.


About:sync Client collection:
------------------------------------
Devices

0: Object

id: "4aaf622c4fca06869d7c656cc6beb528"

isCurrentDevice: false

location: Object

city: "Las Vegas"

country: "United States"

state: "Nevada"

    stateCode: "NV"

name: "Firefox Beta on Softvision’s iPad"

type: "mobile"

pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABbvjsbR9FYfzJ8K8SB6JzAGPya-olbsLTb9U9baaj_hecIl1COtonTD_cwcQcL3ASGz6lXaRSUguKdW_jbFHauTtZAU_FUVoxOyj63z4UkwOpdmvuKIRzOUuT8IZ3j7YoQmM5Y"

pushPublicKey: "BFdy5wPao4Gb360PDt2SLkhM6DauWPyvarpAp_rFyRE3O5JLErJI-nxZMcqQkWW-Rn8ppIRos27usjNSIHP5HjE"

pushAuthKey: "KPSBsRcKqDE6NS42Pqc_aQ"

pushEndpointExpired: false

availableCommands: Object

    https://identity.mozilla.com/cmd/open-uri: "{"ciphertext":"qdeZGOzrnOs8DCMFcZ1/aJrzZayddbl9DceyI0usmpfyoJrtGA2iLucZ25Fg/1mfhb/U5teKA++19tKdDXINyddVfPyZKQG/z5zUuLBHca25mzvSSDsrjmakaoPTMxauKj9AszZdvCA//rG/+KyiZ5f3txZhHKnjcCoY9fvJ42loA6XwmlnEm6vuFHAnZx78","IV":"Cgkqum0MBty0HnmhdW0log==","hmac":"030c01b21275b998dc2a7ca76f505d3b690d9735428009456811050a11c6a1c8","kid":"c970dcdee6ce8f8f0cbdf3d1de82f911"}"

lastAccessTime: 1539194328341

    lastAccessTimeFormatted: "a minute ago"

1: Object

id: "7f36b5330b5e3b3c9e371815075ae349"

isCurrentDevice: true

location: Object

city: "Las Vegas"

country: "United States"

state: "Nevada"

    stateCode: "NV"

name: "kanchan.kumari’s Nightly on SVUS0014"

type: "desktop"

pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABbvjv33-ZYHdftKmmW5Jl96FJSwRCHV61tcPoGQRx5AgDu7a87S9ncnM7y2l86xLjKajkwyB_C7oWjDKMRJ6Wgg3oMzvfItSKIxF-gQEKIzqyLOranblJfyFh1glncM3AUw0II"

pushPublicKey: "BKRehXqyAeeKEPEAL_2zfsbTMoxX6QPxtcW-9hlVZ9WzGQHZA7PNbsFN7vXsuBnAT7zQB4nRXBmh27V0uoQIhsI"

pushAuthKey: "b9nNYEMDrZnRVbAEXBbA7g"

pushEndpointExpired: false

availableCommands: Object

    https://identity.mozilla.com/cmd/open-uri: "{"kid":"c970dcdee6ce8f8f0cbdf3d1de82f911","IV":"wtxYrzj676T41nCHsPNbow==","hmac":"74336cd450df31e5c88eda758c72daa115f3da76d419ea594b73b7693dd0058a","ciphertext":"s0ZqNLR0/8aJoOvJq4uiatexkDMLUPI8C2MWmCN+8oTFIJwgMDEQZUJi0kYQw9FbOlvSWqLPvKKx2ZOEK19utWu9tnsLDhMVC1gbA5CFF3IsX4eUiXi7Uj2RfB/viTBm+fHZTWjUC0UyMEFKNfjV2mCNfRDHpPiXGv7cQxWVtIibU9F43NXZJ5q3FhyLFj4w"}"

lastAccessTime: 1539194270088

    lastAccessTimeFormatted: "2 minutes ago"

2: Object

id: "8fc1839e903bfe093d2c3ead64a42b95"

isCurrentDevice: false

location: Object

city: "Las Vegas"

country: "United States"

state: "Nevada"

    stateCode: "NV"

name: "Firefox 64, Android"

type: "mobile"

pushCallback: null

pushPublicKey: null

pushAuthKey: null

pushEndpointExpired: false

availableCommands: Object

lastAccessTime: 1539193939979

lastAccessTimeFormatted: "8 minutes ago"



FxA device list on desktop:
----------------------


Devices & apps
kanchan.kumari’s Nightly on SVUS0014
Current device

Firefox Beta on Softvision’s iPad
Last sync 14 minutes ago near Las Vegas, NV, United States
Firefox 64, Android
Last sync 20 minutes ago near Las Vegas, NV, United States
Web Session, Firefox iOS 14
11 minutes ago near Las Vegas, NV, United States

FxA device list on Android:
-----------------------------
Firefox 64, Android (current device)
Firefox Beta on Softvision’s iPad
kanchan.kumari’s Nightly on SVUS0014
Web Session, Firefox iOS 14


FxA device list on iPhone:
---------------------------
Firefox Beta on Softvision’s iPad(current device)
Firefox 64, Android
kanchan.kumari’s Nightly on SVUS0014
Web Session, Firefox iOS 14


Send Tab device list on Android:
kanchan.kumari’s Nightly on SVUS0014
Firefox Beta on Softvision’s iPad

Send Tab device list on iPad:
-------------------------------
kanchan.kumari’s Nightly on SVUS0014

kanchan.kumari’s Nightly on iPhone:
-------------------------------------
Nightly on Nexus 5

Send Tab device list on desktop:
---------------------------------
Firefox Beta on Softvision’s iPad
Firefox Beta on Softvision’s iPhone
Nightly on Nexus 5

Please see following video to see About:sync client collections and last sync time for device (showing last time before password reset) in send tab list:

https://svtest2222-gmail.tinytake.com/sf/Mjk4OTAzMV84OTYxNjU2



This time I couldn't exactly reproduce the original bug but I encounter this bug mostly after above STR. Most of the time about:sync clients collections and FxA device list match with each other but not with send tab list. 


On iPhone, after sometime I am getting message 'Enter your password to connect'. Please remember I signed in to iPhone with new password in step #7

I encounter this kind of issues often/intermittently (mostly after password reset) so it's worth investigating for. I will update this bug if encounter this with any other reliable str.

Comment 13

[Kanchan Kumari QA]

Attachment: success-sync-1539209970418.txt

Another STR:
1. Sign in to sync on desktop, iPhone and iPad with new sync account
2. Change password on iPad 
3. Sign back to sync on desktop and iPhone with new password
4. Send tab from desktop to iPad and iPhone

Observed: iPad received tab but iPhone didn’t get tab

Browser console on desktop shows:
Could not find associated FxA device for Firefox Beta on Softvision’s iPhone 
Sending a tab to Firefox Beta on Softvision’s iPad using FxA commands. 


Please see attached sync log.

About:sync device collection:
Devices

0: Object

id: "0e42f747fdeb66ff2416ede2620fb311"

isCurrentDevice: false

location: Object

name: "Firefox Beta on Softvision’s iPad"

type: "mobile"

pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABbvnflEuLNYv_mSowuBCYk-5yxtL1F9Ec97baOK8GlIwMyfU2T-Vho20rFdlc0iRPJRSnYQXybsyc7JxvueqsIQIy3ljqx1SXmws0Tk0FVce8nNF5ZDeYrjxmUTJULPdbP_v6c"

pushPublicKey: "BAQi3qG3BC45am4wUNEUlI80LXU63Sz80DWyCO3SMEPG4Gh-FL8UApA7oXM0jtgGGouuzxCIRvNWTUvKydzWa_8"

pushAuthKey: "X_67cs7-aV58KoPAVgll_w"

pushEndpointExpired: false

availableCommands: Object

lastAccessTime: 1539209692589

    lastAccessTimeFormatted: "2 minutes ago"

1: Object

id: "6c9970906f14f19b3708848d853765ff"

isCurrentDevice: true

location: Object

name: "kanchan.kumari’s Nightly on SVUS0014"

type: "desktop"

pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABbvngR7MBTNagKRG5PPfeMkrm9-uUXH2uYrGCrr2MkaiHYA3VbyBtsDluM7PINPJr8ye1UK6dd8l7bf2qRivAvqNpzJcJuxbwLTZa14HNKHkqcJoLGzY7aLthnw-3cH6GYQAIC"

pushPublicKey: "BEVQJZ1kjv4yU7CKJWEtRVQ_vZ5w1nSpC-3QY-k8FF-NDaCsaHkZXBQ4cofARYHRihQLGKpqvFdGPySIMJxucJc"

pushAuthKey: "nbZqlfSrww1s6MJJLiH4cg"

pushEndpointExpired: false

availableCommands: Object

lastAccessTime: 1539209250427

lastAccessTimeFormatted: "10 minutes ago"

Comment 15

[Alex Davis [:adavis]]

(In reply to Kanchan Kumari QA from comment #0)
> 4. Restart browser on desktops
>  Device list differs from send tab list. Please see attached image

The different device list in normal. We remove your current device from Send Tab. There is no value in sending to your current device. The other item in device manager is a service to which we cannot send a tab.

So, this part is behaving as expected IMO.

As per send tab not working after a password change, that seems normal since devices should get disconnected after a password change. To me, the question are: 

- why is Android still able to send?
- are we not putting any visuals to inform the user that they need to sign back into to the other browser? (I think the answer to this is no)

> iOS device is out of Sync here

This is as expected IMO since iOS should have been disconnected after the password change.
Question: was there poor UX to tell the user that their device was disconnected?


Note: it is my desire that in the future, we investigate the possibility of keeping devices connected after a password change (not a password reset) but for the time being, it is normal that devices get disconnected with a password change.

Comment 16

[Alex Davis [:adavis]]

(In reply to Kanchan Kumari QA from comment #9)
> Created attachment 9014521 [details]
> logs.7z
> 
> I was able to reproduce this bug today. After password reset on ipad and
> signing back to other three devices (iPhone, Android and desktop) with new
> password. Now about:sync, FxA setting page and send tab shows different
> device list. Please see video below
> 
> https://svtest2222-gmail.tinytake.com/sf/Mjk3MjM5MF84OTE1Nzk1
> 
> I made sure iPhone is connected (signed in with new password). FxA device
> list and send device list is out of sync on all devices.
> 
> 1. iPhone doesn't appear on Android send tab list but appears under FxA
> device list. 
> 2. Tab is getting send from iOS to Android  and received on Android
> notification after manual sync on android phone. 
> 3. iPhone appears in FxA device list on all other three devices but not in
> send tab list on android and iPad.  
> 4. iPhone send tab device list does not show iPad vice versa iPad doesn't
> show iPhone in send tab device list
> 5. iphone is not sending/receiving tab from desktop though they appear under
> each other's send tab list. Desktop shows wrong last sync time for iPhone.
> 
> 
> I am attaching sync logs too in case it's useful to you.

Obviously, I had to write the other comment to land on this where you mention that you did sign back into the other devices.

If this is the case then there is a bug on any device that is not properly syncing after a password change.

Comment 17

[Alex Davis [:adavis]]

Edouard, how is this bug different from:

https://bugzilla.mozilla.org/show_bug.cgi?id=1497977

Is it simply that one if for password change and the other password reset?

Does the other one resolve this bug?

Comment 18

[Edouard Oger [:eoger]]

This is the iOS counterpart of bug 1497977, work still needs to be done.

Comment 19

[Edouard Oger [:eoger]]

This need to be done at some point, nominating for triage (should be P2 in my opinion).

Comment 20

[Justin D'Arcangelo [:justindarc]]

Bumping to P3 for now. We can try to do this work for v16. This is the counterpart of Bug 1497977 which is a fairly large 6-part patch.