Search em-dash should be hidden when search query only contains spaces

RESOLVED FIXED in Firefox 63

Status

()

P1
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: adw, Assigned: adw)

Tracking

Trunk
Firefox 63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
STR

1. Focus urlbar
2. Remove the text
3. Start typing spaces

The first result shows " – Search with Foo" but it should just show "Search with Foo".

We need to trim() the searchQuery here: https://hg.mozilla.org/mozilla-central/file/36642e9b970a/toolkit/content/widgets/autocomplete.xml#l1865
(Assignee)

Comment 1

6 months ago
Created attachment 9002100 [details]
Bug 1484067 - Hide search em-dash when search query only contains spaces

Comment 2

6 months ago
Comment on attachment 9002100 [details]
Bug 1484067 - Hide search em-dash when search query only contains spaces

Ed Lee :Mardak (PTO Aug 11-26) has approved the revision.
Attachment #9002100 - Flags: review+

Comment 3

6 months ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92102de55ba4
Hide search em-dash when search query only contains spaces r=Mardak

Comment 4

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/92102de55ba4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.