Closed Bug 1484067 Opened 3 years ago Closed 3 years ago

Search em-dash should be hidden when search query only contains spaces

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

Bug 1484067 - Hide search em-dash when search query only contains spaces
46 bytes, text/x-phabricator-request
Mardak
: review+
Details | Review 
STR

1. Focus urlbar
2. Remove the text
3. Start typing spaces

The first result shows " – Search with Foo" but it should just show "Search with Foo".

We need to trim() the searchQuery here: https://hg.mozilla.org/mozilla-central/file/36642e9b970a/toolkit/content/widgets/autocomplete.xml#l1865
Comment on attachment 9002100 [details]
Bug 1484067 - Hide search em-dash when search query only contains spaces

Ed Lee :Mardak (PTO Aug 11-26) has approved the revision.
Attachment #9002100 - Flags: review+
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92102de55ba4
Hide search em-dash when search query only contains spaces r=Mardak
https://hg.mozilla.org/mozilla-central/rev/92102de55ba4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.