1484128 - Split HTMLEditor::GetFirstSelectedCell() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484128 - part 0: Add automated tests for nsITableEditor::GetFirstSelectedCell()

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484128 - part 1: Create HTMLEditor::GetFirstSelectedTableCellElement() for internal use of HTMLEditor::GetFirstSelectedCell()

HTMLEditor::GetFirstSelectedCell() is an XPCOM method, but used internally a
lot.  Therefore, we should create a non-virtual method for internal use.

This patch creates HTMLEditor::GetFirstSelectedTableCellElement(), and it
won't return NS_SUCCESS_EDITOR_ELEMENT_NOT_FOUND since nobody needs the
value.  It's enough to check whether the result is nullptr without error for
any callers.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 9003398 [details]
Bug 1484128 - part 1: Create HTMLEditor::GetFirstSelectedTableCellElement() for internal use of HTMLEditor::GetFirstSelectedCell()

Makoto Kato [:m_kato] has approved the revision.

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 9003397 [details]
Bug 1484128 - part 0: Add automated tests for nsITableEditor::GetFirstSelectedCell()

Makoto Kato [:m_kato] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f45ff1131eb
part 0: Add automated tests for nsITableEditor::GetFirstSelectedCell() r=m_kato

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90f962c6f3df
part 1: Create HTMLEditor::GetFirstSelectedTableCellElement() for internal use of HTMLEditor::GetFirstSelectedCell() r=m_kato

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/7f45ff1131eb
https://hg.mozilla.org/mozilla-central/rev/90f962c6f3df