1484148 - Follow-ups to Web Animations and CSS transitions tests

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P3)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

This bug tracks following up on some of the outstanding feedback from bug 1467344 since I really just want to land that before it bitrots.

Specifically:

* We need to add a test for resuming a paused animation (see end of bug 1467344 comment 40)
* We need to make the "Seeking a transition using start time dispatches transition events" test timeout after a couple of frames of waiting for events (see bug 1467344 comment 34).

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1484148 - Add a test for resuming from paused; r=hiro

As bug 1467344 comment 40, it appears we don't currently have any tests that
cover resuming a paused animation.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1484148 - Make CSSTransition startTime test timeout when waiting for transition events after a fixed number of frames; r=hiro

See bug 1467344 comment 34.

Depends on D3752

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=994bbc5016afd60dc9fe5b81861be988a1c64cbe

(Forgot to add the TV job though... I'll try to add it later once the decision task runs.)

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Couldn't work out how to add the verify jobs after the fact so I re-submitted:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b81a22882fbec848257f380114b7b55db05af1b5

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 9002360 [details]
Bug 1484148 - Add a test for resuming from paused; r=hiro

Hiroyuki Ikezoe (:hiro) (PTO on Aug 20, Offline from Aug 18 to Aug 20) has approved the revision.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 9002361 [details]
Bug 1484148 - Make CSSTransition startTime test timeout when waiting for transition events after a fixed number of frames; r=hiro

Hiroyuki Ikezoe (:hiro) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0eda3c4965
Add a test for resuming from paused; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfac768978de
Make CSSTransition startTime test timeout when waiting for transition events after a fixed number of frames; r=hiro

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12581 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ba0eda3c4965
https://hg.mozilla.org/mozilla-central/rev/dfac768978de

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged