Closed Bug 1484150 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12543 - Fix cookie prefix tests.

Categories

(Core :: Networking: Cookies, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream][necko-triaged])

Sync web-platform-tests PR 12543 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12543
Details from upstream follow.

Mike West <mkwst@chromium.org> wrote:
>  Fix cookie prefix tests.
>  
>  The layout tests aren't testing much at the moment, as they're never
>  served over HTTPS. This patch creates `.https` versions of the tests
>  and reworks them to actually exercise the behavior of `__Host` and
>  `__Secure` cookie prefixes.
>  
>  Bug: 843945
>  Change-Id: I31968133ca8846f3ffc4faec2339e3d0d03c77f8
>  Reviewed-on: https://chromium-review.googlesource.com/1179150
>  WPT-Export-Revision: de3c0640c08a71ef9bf03d33ca0e85cd91b595da
Component: web-platform-tests → Networking: Cookies
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Priority: P4 → P3
Whiteboard: [wptsync downstream error] → [wptsync downstream error][necko-triaged]
Whiteboard: [wptsync downstream error][necko-triaged] → [wptsync downstream][necko-triaged]
Ran 21 tests and 169 subtests
OK     : 20
PASS   : 137
FAIL   : 32
ERROR  : 1

New tests that have failures or other problems:
/cookies/prefix/__secure.header.https.html
    __Secure: secure origin: Should not set 'Path=/;': FAIL
    __Secure: secure origin: Should not set 'Path=/;HttpOnly': FAIL
    __Secure: secure origin: Should not set 'Path=/;MaxAge=10': FAIL
    __Secure: secure origin: Should not set 'Path=/;domain=not-web-platform.test': FAIL
    __Secure: secure origin: Should set 'Secure;Path=/;': FAIL
    __Secure: secure origin: Should set 'Secure;Path=/;HttpOnly': FAIL
    __Secure: secure origin: Should set 'Secure;Path=/;MaxAge=10': FAIL
    __Secure: secure origin: Should set 'Secure;Path=/;domain=not-web-platform.test': FAIL
Priority: P3 → P4
Whiteboard: [wptsync downstream][necko-triaged] → [wptsync downstream]
We don't use P4 in necko.
However it's pointless to change the priority back and forth. Simply mark it triaged.
Whiteboard: [wptsync downstream] → [wptsync downstream][necko-triaged]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21ea0e12a53b
[wpt PR 12543] - Fix cookie prefix tests., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7174f9d6e64
[wpt PR 12543] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/21ea0e12a53b
https://hg.mozilla.org/mozilla-central/rev/b7174f9d6e64
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.