Closed Bug 1484154 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12544 - Support CSSStyleValues in StylePropertyMap.set. (Reland)

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12544 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12544
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  Support CSSStyleValues in StylePropertyMap.set. (Reland)
>  
>  In StyleValueToCSSValue, when checking whether a certain CSSStyleValue
>  matches the property in question, we now ask the registration (via
>  CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw
>  a TypeError like for normal properties. If it does match, the CSSStyleValue
>  is stringified, tokenized, and set on the style rule as tokens.
>  
>  I have postponed support for <color> and <transform-function>, because
>  CSSUnsupportedStyleValue currently does not handle registered custom
>  properties at all. This is appropriate to fix in a separate CL.
>  
>  Note that, because the string version of StylePropertyMap.set also uses
>  StyleValueToCSSValue, it will no longer be possible to set registered
>  custom properties with a string--even if the syntax is matched.
>  A subsequent CL will fix this.
>  
>  R=futhark@chromium.org
>  
>  Bug: 641877
>  Change-Id: Ib5c31640f81e957620339c9bdf617ab1af5d3d47
>  Reviewed-on: https://chromium-review.googlesource.com/1179153
>  WPT-Export-Revision: ad314be2cebb6358d78a9a06fb210f53fc25b2d8
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 42 subtests
FAIL   : 42
ERROR  : 1

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-properties-values-api/typedom.tentative.html: ERROR
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0131ba65ffa2
[wpt PR 12544] - Support CSSStyleValues in StylePropertyMap.set. (Reland), a=testonly
https://hg.mozilla.org/mozilla-central/rev/0131ba65ffa2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.