Status

enhancement
VERIFIED FIXED
10 months ago
10 months ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

10 months ago
15.8 can build the tree without ICE.
Assignee

Comment 1

10 months ago
Attachment #9001941 - Flags: review?(core-build-config-reviews)
Assignee

Updated

10 months ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Assignee

Updated

10 months ago
Depends on: 1484191
Comment on attachment 9001941 [details] [diff] [review]
Unblock MSVC 2017 15.8

Review of attachment 9001941 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the error message and also the MDN page that it references.
Attachment #9001941 - Flags: review?(core-build-config-reviews) → review+
Assignee

Updated

10 months ago
Flags: needinfo?(VYV03354)

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/574377aa4586
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
(In reply to David Major [:dmajor] from comment #2)
> Please update the error message and also the MDN page that it references.

I updated the page (https://developer.mozilla.org/en/Windows_Build_Prerequisites, which redirects to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites for me) to note that Visual Studio 2017 Update 8 is supported.
Status: RESOLVED → VERIFIED

Comment 8

10 months ago
FYI, because MS released the final 15.8 update, when downloading the VS Community edition now, it will always install 15.8-level compilers. 

May I suggest to simplify the wording on the Windows_Build_Prerequisites page to just talk about 15.8 (and optionally leave a note with the link to "Installing an Earlier Release of VS" only for folks that need to stay behind for other reasons unrelated to building Firefox)?

-- Marian, Visual C++ team
You need to log in before you can comment on or make changes to this bug.