15.8 can build the tree without ICE.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 9001941 [details] [diff] [review] Unblock MSVC 2017 15.8 Review of attachment 9001941 [details] [diff] [review]: ----------------------------------------------------------------- Please update the error message and also the MDN page that it references.
Attachment #9001941 - Flags: review?(core-build-config-reviews) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/dca5444170e0 Unblock MSVC 2017 15.8. r=dmajor
Backed out for bustages on test_toolchain_configure.py Push link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=dca5444170e0a59c7a3a5321bece62d717fb6c1a Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/2e949e5a9a62d0db0d33833e1e875f12f2969ac4 Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=194880403&repo=mozilla-inbound&lineNumber=41172
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/574377aa4586 Unblock MSVC 2017 15.8. r=dmajor
(In reply to David Major [:dmajor] from comment #2) > Please update the error message and also the MDN page that it references. I updated the page (https://developer.mozilla.org/en/Windows_Build_Prerequisites, which redirects to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites for me) to note that Visual Studio 2017 Update 8 is supported.
Status: RESOLVED → VERIFIED
FYI, because MS released the final 15.8 update, when downloading the VS Community edition now, it will always install 15.8-level compilers. May I suggest to simplify the wording on the Windows_Build_Prerequisites page to just talk about 15.8 (and optionally leave a note with the link to "Installing an Earlier Release of VS" only for folks that need to stay behind for other reasons unrelated to building Firefox)? -- Marian, Visual C++ team
You need to log in before you can comment on or make changes to this bug.