Closed
Bug 1484191
Opened 6 years ago
Closed 6 years ago
Suppress warning C4819 in TestMimeType.cpp
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file)
1.57 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
MSVC 2017 15.8 complains C4819 that is harmless here.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9001943 -
Flags: review?(core-build-config-reviews)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment 2•6 years ago
|
||
Comment on attachment 9001943 [details] [diff] [review] Suppress warning C4819 in TestMimeType.cpp Review of attachment 9001943 [details] [diff] [review]: ----------------------------------------------------------------- That seems like a bad error, since we don't actually have the *literal* character...unless MSVC is parsing as an 8-bit string, discovering the 16-bit character, and complaining before the preprocessor glues on the L prefix? Have you filed a bug with Microsoft?
Attachment #9001943 -
Flags: review?(core-build-config-reviews) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/2a42fd4df1bb Suppress warning C4819 in TestMimeType.cpp. r=froydnj
Comment 4•6 years ago
|
||
Backed out for bustages on test_toolchain_configure.py Push link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=dca5444170e0a59c7a3a5321bece62d717fb6c1a Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/2e949e5a9a62d0db0d33833e1e875f12f2969ac4 Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=194880403&repo=mozilla-inbound&lineNumber=41172
Flags: needinfo?(VYV03354)
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/407f1b80fd8a Suppress warning C4819 in TestMimeType.cpp. r=froydnj
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/407f1b80fd8a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•