Closed Bug 1484232 Opened 4 years ago Closed 3 years ago

Switch order of Google params and remove unused params

Categories

(Firefox :: Search, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(1 file)

In looking at some of our data, it's become clear that many users go to the URL bar after a search and add data to the end of the URL to try to do another search.

Because of the way our URL is:

https://www.google.com/search?q=test&ie=utf-8&oe=utf-8&client=firefox-b-1-ab

This just results in an incorrect code:

https://www.google.com/search?q=test&ie=utf-8&oe=utf-8&client=firefox-b-1-abadditional info.

And I am definitely seeing searches like this.

I'd like to suggest that we change our engine so that it orders things like this:

https://www.google.com/search?client=firefox-b-1-ab&q=test

I'd also like to suggest that we remove ie and oe since they are no longer used.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment on attachment 9002036 [details]
Bug 1484232 - Move query to end and remove unused params.

Mike de Boer [:mikedeboer] has approved the revision.
Attachment #9002036 - Flags: review+
Priority: -- → P1
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/7a8e8fa7a3f0
Move query to end and remove unused params. r=mikedeboer
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfd436600d63
Backed out changeset 7a8e8fa7a3f0 as per mkaply`s request.
Depends on: 1485508
Mike, can this land?  Does it really need to be a P1 if not?
Flags: needinfo?(mozilla)
I'll double check now that the other patch in, but yes, I'll get this landed tomorrow.
Flags: needinfo?(mozilla)
It's working locally, doing a try run then I'll get landed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c6b33aefdaf74c641ea64890614338701844d88
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/9d781037111b
Move query to end and remove unused params. r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/9d781037111b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.