Closed Bug 1484248 Opened 2 years ago Closed 1 year ago

Accessible name calculation from label content should include descendant table cells

Categories

(Core :: Disability Access APIs, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jdiggs, Assigned: jdiggs)

Details

Attachments

(1 file)

Given this test case:

  <input type="text" id="test" />
  <label for="test" id="label">
    <div>foo</div>
    <table><tr><td>bar</td></tr></table>
    <div>baz</div>
  </label>

Expected results: Accessible name of the input with id of "test" would be "foo bar baz".

Actual results: Accessible name of the input with id of "test" is "foo baz".
One line fix assuming no issues. Please review. Thanks and happy Friday! :)
Assignee: nobody → jdiggs
Status: NEW → ASSIGNED
Attachment #9001989 - Flags: review?(surkov.alexander)
Attachment #9001989 - Flags: review?(mzehe)
Attachment #9001989 - Flags: review?(jteh)
Comment on attachment 9001989 [details] [diff] [review]
0001-Bug-1484248-Accessible-name-calculation-from-label-c.patch

Review of attachment 9001989 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, one review should be enough for a such small change
Attachment #9001989 - Flags: review?(surkov.alexander)
Attachment #9001989 - Flags: review?(mzehe)
Attachment #9001989 - Flags: review?(jteh)
Attachment #9001989 - Flags: review+
Keywords: checkin-needed
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10656d316573
Accessible name calculation from label content should include cells. r=surkov
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/10656d316573
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.