1484248 - Accessible name calculation from label content should include descendant table cells

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Joanmarie Diggs]

Given this test case:

  <input type="text" id="test" />
  <label for="test" id="label">
    <div>foo</div>
    <table><tr><td>bar</td></tr></table>
    <div>baz</div>
  </label>

Expected results: Accessible name of the input with id of "test" would be "foo bar baz".

Actual results: Accessible name of the input with id of "test" is "foo baz".

Comment 1

[Joanmarie Diggs]

Attachment: 0001-Bug-1484248-Accessible-name-calculation-from-label-c.patch

One line fix assuming no issues. Please review. Thanks and happy Friday! :)

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 9001989 [details] [diff] [review]
0001-Bug-1484248-Accessible-name-calculation-from-label-c.patch

Review of attachment 9001989 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, one review should be enough for a such small change

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10656d316573
Accessible name calculation from label content should include cells. r=surkov

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/10656d316573