Closed
Bug 1484250
Opened 6 years ago
Closed 6 years ago
Remove conditional where we only close windowserver connections if we're not running under webreplay
Categories
(Core :: Security: Process Sandboxing, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: Alex_Gaynor, Assigned: bhackett1024)
Details
Attachments
(1 file)
|
1.94 KB,
patch
|
Alex_Gaynor
:
review+
|
Details | Diff | Splinter Review |
https://searchfox.org/mozilla-central/source/dom/ipc/ContentChild.cpp#1644-1648 Right now removing the |if| and closing connections unconditionally breaks one of the webreplay tests. We should figure out why that is, and fix it.
|
Assignee | |
Comment 1•6 years ago
|
||
This patch seems to fix the problem, see https://treeherder.mozilla.org/#/jobs?repo=try&revision=38e14bed87a5. It looks like CGSShutdownServerConnections does not alias another API on 10.10 like it does in later OS versions.
Assignee: nobody → bhackett1024
Attachment #9002640 -
Flags: review?(agaynor)
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9002640 [details] [diff] [review] patch Review of attachment 9002640 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for diving into this!
Attachment #9002640 -
Flags: review?(agaynor) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c6552a729ea7 Fix redirection for CGSShutdownServerConnections on 10.10, r=alex_gaynor.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c6552a729ea7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•