Closed Bug 1484294 Opened 6 years ago Closed 6 years ago

2.04% Resident Memory (android-em-4-2-x86) regression on push 18b999f1a4c141c31d83d13842de6231a774a34c (Thu Aug 16 2018)

Categories

(Web Compatibility :: Interventions, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jmaher, Unassigned)

References

Details

(Keywords: perf, regression)

We have detected an awsy regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=18b999f1a4c141c31d83d13842de6231a774a34c

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  2%  Resident Memory android-em-4-2-x86 opt      150,497,570.67 -> 153,569,445.25


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=15079

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/AWSY/Tests
Component: General → Go Faster
Product: Testing → Web Compatibility Tools
:denschub, I see you added this addon to fennec, we see a regression from that in our memory- can you confirm this is expected, or work on fixing this?
Flags: needinfo?(dschubert)
Thanks for the ping, Joel! Yeah, we added a new system extension to Fennec, and a small increase in memory is, unfortunately, expected. Similar to the regressions in bug 1472110, I think we have to accept it for now, as the ability to fix websites is more important here. A 3MB increase in RSS seems fine to me, and I actually expect this to make it easier for other system extensions, since there probably is a lot of WebExtension framework code in that memory.

I ran some tests and did not spot any increasing memory usage, so we don't leak something, so the increase in memory is really just WebExtension stuff and our site patches. So for me, this feels fine.

However, I'd like a second opinion, so... Mike? :)
Flags: needinfo?(dschubert) → needinfo?(miket)
Yes, we should eat this regression (unfortunately...) in order to enable this webcompat feature. Thanks.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(miket)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.