1484304 - 8.75 - 9.88% build times / sccache hit rate (windows2012-32) regression on push 5fcbe08fb321a5076f56c380b554c63068efbb00 (Thu Aug 16 2018)

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=5fcbe08fb321a5076f56c380b554c63068efbb00

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

 10%  build times windows2012-32 pgo taskcluster-c4.4xlarge     4,406.64 -> 4,842.06
  9%  sccache hit rate windows2012-32 pgo taskcluster-c4.4xlarge0.90 -> 0.98
  9%  build times windows2012-32 pgo taskcluster-c5.4xlarge     3,727.22 -> 4,053.25


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=15105

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:glandium, I see in bug 1483779 that you switched pgo on for clang-cl builds, is this an expected regression in build times?

Comment 2

[Mike Hommey [:glandium]]

Yes, obviously.

When will sccache hit rate tracking know that going up is not a regression?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

:ted.m is one of the primary contacts for the build metrics, he could fix that.

Comment 4

[Ionuț Goldan [:igoldan]]

(In reply to Joel Maher ( :jmaher ) (UTC+2) from comment #3)
> :ted.m is one of the primary contacts for the build metrics, he could fix
> that.

I'm currently working on bug 1411304, which should address this issue. Canceling the needinfo?.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

:igoldan, Is this bug resolved  now?

Comment 6

[Ionuț Goldan [:igoldan]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #5)
> :igoldan, Is this bug resolved  now?

In terms of build times, not in the slightest of ways. It never returned to the prior baseline, but it did increase constantly on Windows 32bit.

Comment 7

[Ionuț Goldan [:igoldan]]

Closing this as WONTFIX, given https://bugzilla.mozilla.org/show_bug.cgi?id=1484304#c2