Closed
Bug 1484324
Opened 6 years ago
Closed 6 years ago
Perma Android bustage due to duplicate files from webcompat addon when Gecko 63 merges to Beta on 2018-08-27
Categories
(Web Compatibility :: Interventions, defect)
Web Compatibility
Interventions
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aryx, Unassigned)
References
Details
Bug 1338586 added injections: https://hg.mozilla.org/mozilla-central/rev/18b999f1a4c1 which cause Android builds in beta simulations to break: https://treeherder.mozilla.org/#/jobs?repo=try&revision=154722dd578a8e9b826292e708ef7448b6a5f373&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=194525661 Log: https://treeherder.mozilla.org/logviewer.html#?job_id=194525661&repo=try [task 2018-08-17T12:58:48.930Z] 12:58:48 INFO - package> ERROR: The following duplicated files are not allowed: [task 2018-08-17T12:58:48.930Z] 12:58:48 INFO - package> features/webcompat@mozilla.org/webextension/injections/js/bug1472081-election.gov.np-window.sidebar-shim.js [task 2018-08-17T12:58:48.931Z] 12:58:48 INFO - package> features/webcompat@mozilla.org/webextension/injections/js/bug1482066-portalminasnet.com-window.sidebar-shim.js [task 2018-08-17T12:58:48.931Z] 12:58:48 INFO - package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:22: recipe for target 'stage-package' failed [task 2018-08-17T12:58:48.931Z] 12:58:48 INFO - package> make[3]: *** [stage-package] Error 1 [task 2018-08-17T12:58:48.931Z] 12:58:48 INFO - package> make[3]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mobile/android/installer' [task 2018-08-17T12:58:48.931Z] 12:58:48 INFO - package> /builds/worker/workspace/build/src/mobile/android/build.mk:11: recipe for target 'package' failed [task 2018-08-17T12:58:48.931Z] 12:58:48 INFO - package> make[2]: *** [package] Error 2 [task 2018-08-17T12:58:48.932Z] 12:58:48 INFO - /builds/worker/workspace/build/src/build/moz-automation.mk:89: recipe for target 'automation/package' failed [task 2018-08-17T12:58:48.932Z] 12:58:48 INFO - make[1]: *** [automation/package] Error 2
Flags: needinfo?(dschubert)
Comment 1•6 years ago
|
||
Note: As Sebastian told me on IRC, we strip the comments out of the packaged files and then those two overrides do indeed match. Will find a workaround for that on Monday!
Reporter | ||
Comment 2•6 years ago
|
||
JS minification gets called at https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/toolkit/mozapps/installer/packager.mk#29
Reporter | ||
Comment 3•6 years ago
|
||
Fixed by bug 1484796.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(dschubert)
Resolution: --- → FIXED
Reporter | ||
Comment 4•6 years ago
|
||
Verified fixed with today's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7564b93e5c70c4d2ce205a9c3c934d54bfd9e06d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•