1484344 - D3D11DXVA2Manager::CopyToImage causes D3D11 errors if debug-layer is enabled

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: aboutSupport.txt

STR:
- Navigate to about:config
- Set `gfx.direct3d11.enable-debug-layer` to true
- Restart Firefox and attach Visual Studio debugger to all processes
- Watch a video, e.g. https://www.youtube.com/watch?v=uBJq-XCP27c. Firefox may spawn another process that needs to be attached to.
- Observe the following errors in the Visual Studio output:
> D3D11 ERROR: ID3D11DeviceContext::CopySubresourceRegion: When offset by the destination coordinates, pSrcBox does not fit on the destination subresource. OffsetSrcBox = { left:0, top:0, front:0, right:1920, bottom:1088, back:1 }. DstSubresource = { left:0, top:0, front:0, right:1920, bottom:1080, back:1 }. [ RESOURCE_MANIPULATION ERROR #280: COPYSUBRESOURCEREGION_INVALIDSOURCEBOX]

> D3D11 ERROR: ID3D11DeviceContext::CopySubresourceRegion: Cannot invoke CopySubresourceRegion when the Formats of each Resource are not the same or at least castable to each other, unless one format is compressed (DXGI_FORMAT_R9G9B9E5_SHAREDEXP, or DXGI_FORMAT_BC[1,2,3,4,5]_* ) and the source format is similar to the dest according to: BC[1|4] ~= R16G16B16A16|R32G32, BC[2|3|5] ~= R32G32B32A32, R9G9B9E5_SHAREDEXP ~= R32. [ RESOURCE_MANIPULATION ERROR #281: COPYSUBRESOURCEREGION_INVALIDSOURCE]

> D3D11 ERROR: ID3D11DeviceContext::CopySubresourceRegion: CopySubresourceRegion requires that this format use a SrcBox whose top, left and right meet alignment requirements.  The right and bottom must also meet alignment requirements or fall upon the right or bottom edge of the texture respectively.*pDstBox = { {left:0, top:0, front:0}, {right:1, bottom:1, back:1} }. NV12 requires alignment of coodinates to multiples of {2, 2, 1}. [ RESOURCE_MANIPULATION ERROR #288: UPDATESUBRESOURCE_INVALIDDESTINATIONBOX]

Videos still seem to render correctly, despite the errors.

The First error seems to correspond to this line[0], as checked by stepping over it. The later errors come from stepping over this[1] line. Stepping into that line the specific call giving the error output is here[2].

This is on a local build from central with no modifications.

[0]: https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/dom/media/platforms/wmf/DXVA2Manager.cpp#965
[1]: https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/dom/media/platforms/wmf/DXVA2Manager.cpp#989
[2]: https://searchfox.org/mozilla-central/rev/5dbfd833bbb114afe758db4d4bdbc5b13bcc33ef/gfx/layers/d3d11/TextureD3D11.cpp#1850