Closed Bug 1484360 Opened 2 years ago Closed 2 years ago

Remove UNSET_DISPLAY in nsCSSFrameConstructor.cpp

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(1 file)

UNSET_DISPLAY is not an actually StyleDisplay value. It's used by some function as undetermined StyleDisplay. https://searchfox.org/mozilla-central/rev/246f2b4fab2c1a6cca99418bc2e4d73d1102cc38/layout/base/nsCSSFrameConstructor.cpp#6273

Quote a possible solution from emilio on #layout IRC.
<•emilio> TYLin: could be removed using `Maybe<StyleDisplay>&` instead for `FindPreviousSibling` & co.
1:23 PM 
<•emilio> TYLin: then using `display.isNothing()` instead of `== UNSET_DISPLAY`
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Comment on attachment 9002174 [details]
Bug 1484360 - Remove UNSET_DISPLAY in nsCSSFrameConstructor.

Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #9002174 - Flags: review+
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/eef8c5edb73c
Remove UNSET_DISPLAY in nsCSSFrameConstructor. r=emilio
https://hg.mozilla.org/mozilla-central/rev/eef8c5edb73c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.