1484371 - Consider to make *enter/*leave events uncomposed

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: enter_leave_uncomposed.diff

See https://github.com/w3c/uievents/issues/208
and https://bugzilla.mozilla.org/show_bug.cgi?id=1478959

https://treeherder.mozilla.org/#/jobs?repo=try&revision=082cf7186b099e240f617c6ceb0ded30190908af

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://github.com/w3c/uievents/issues/208#issuecomment-413963206 sounds like at least Apple would be ok with this. Trying to get feedback from Google and MS too.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: composed_enterleave.diff

Based on the github issue, sound like people in general are in favor of the change. I'd rather fix our behavior sooner than later, so that pages like ea.com works with shadow DOM enabled FF.

The test is very simple but enough to cover the change.

remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4e3946334ea25b05ef1bda76b091506e5f0ff1f
remote: recorded changegroup in replication log in 0.011s

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9002926 [details] [diff] [review]
composed_enterleave.diff

Review of attachment 9002926 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/test/file_bug1484371.html
@@ +24,5 @@
> +        return "onpointerenter" in document.body;
> +      }
> +
> +      function checkEventCounts(expected) {
> +        parent.is(mouseEnterCount, expected.mouseEnterCount, "mouseenter event count");

Please make checkEventCounts take prefix string for the parent.is(). E.g., I like "moving on lightDiv: mouseenter event count" instead of jus t"mouseenter event count".

::: dom/events/test/mochitest.ini
@@ +205,5 @@
>  [test_bug1447993.html]
>  support-files = window_bug1447993.html
>  skip-if = toolkit == 'android'
> +[test_bug1484371.html]
> +support-files = file_bug1484371.html

Hmm, I like test_mouse_enter_leave_event_count_on_shadow_host.html or something to explain what this check since this is not Gecko's bug from a point of view of future developers, just conforming to (new) spec. But up to you.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: untested

(would need to update everything on this older laptop to be able to compile Nightly. Will test and land in a moment using another laptop)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/971943621f6e
make *enter/*leave events uncomposed, r=masayuki

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/971943621f6e