Closed Bug 1484382 Opened 2 years ago Closed 2 years ago

Use mozilla::ScopedExit instead of custom types when reasonable (js/src)

Categories

(Core :: JavaScript Engine, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

Details

Attachments

(1 file, 1 obsolete file)

We have a few custom types used once and only defining a destructor so they should probably be using mozilla::ScopedExit instead.
- Remove AutoDeleteDebugModeOSRInfo
- Remove AutoResetLastProfilerFrameOnReturnFromException
- Remove AutoFreeProfilingStrings
- Remove DestroyTypeNewScript
- Remove AutoFreeProfilingStrings
- Remove DestroyTypeNewScript

- Cleanup CCW iterator reification. Replace AutoCloseIterator with
  mozilla::ScopeExit. Also Bug 831626 means we don't have to stress about
  iterator cleanup ordering.
Bug 1484382 - Use mozilla::ScopeExit in jit/JitFrames.cpp
Bug 1484382 - Use mozilla::ScopeExit in vm/TypeInference.cpp
Bug 1484382 - Use mozilla::ScopeExit in jit/JitcodeMap.cpp
Bug 1484382 - Use mozilla::ScopeExit in jit/JitFrames.cpp
Attachment #9002160 - Attachment is obsolete: true
Comment on attachment 9002164 [details]
Bug 1484382 - Use mozilla::ScopeExit in js/src

Jan de Mooij [:jandem] has approved the revision.
Attachment #9002164 - Flags: review+
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed07516ab49e
Use mozilla::ScopeExit in js/src r=jandem
https://hg.mozilla.org/mozilla-central/rev/ed07516ab49e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.