1484382 - Use mozilla::ScopedExit instead of custom types when reasonable (js/src)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P5)

Description

[Ted Campbell [:tcampbell]]

We have a few custom types used once and only defining a destructor so they should probably be using mozilla::ScopedExit instead.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1484382 - Use mozilla::ScopeExit in js/src

- Remove AutoDeleteDebugModeOSRInfo
- Remove AutoResetLastProfilerFrameOnReturnFromException
- Remove AutoFreeProfilingStrings
- Remove DestroyTypeNewScript
- Remove AutoFreeProfilingStrings
- Remove DestroyTypeNewScript

- Cleanup CCW iterator reification. Replace AutoCloseIterator with
  mozilla::ScopeExit. Also Bug 831626 means we don't have to stress about
  iterator cleanup ordering.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1484382 - Use mozilla::ScopeExit in js/src

Bug 1484382 - Use mozilla::ScopeExit in jit/JitFrames.cpp
Bug 1484382 - Use mozilla::ScopeExit in vm/TypeInference.cpp
Bug 1484382 - Use mozilla::ScopeExit in jit/JitcodeMap.cpp
Bug 1484382 - Use mozilla::ScopeExit in jit/JitFrames.cpp

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 9002164 [details]
Bug 1484382 - Use mozilla::ScopeExit in js/src

Jan de Mooij [:jandem] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed07516ab49e
Use mozilla::ScopeExit in js/src r=jandem

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ed07516ab49e