Closed
Bug 1484385
Opened 4 years ago
Closed 4 years ago
Move various error-report-related structures and types into js/public/ErrorReport.h
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
Attachments
(1 file)
17.77 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
I'm fixing bug 1033916 and removing the jsfriendapi.h -> jsapi.h dependency, and this has to happen for that to happen. These APIs are not nearly as clean/nice as I would prefer, for them to be promoted to js/public status, but cleaning this stuff up to be closer to spec sensibilities is not a short-term change or design thing, so this is about the best we can do, IMO.
Attachment #9002154 -
Flags: review?(jdemooij)
Comment 2•4 years ago
|
||
Comment on attachment 9002154 [details] [diff] [review] Patch Review of attachment 9002154 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, JSExnType and these #defines hurt :) but that's all pre-existing and this is a step in the right direction.
Attachment #9002154 -
Flags: review?(jdemooij) → review+
Updated•4 years ago
|
Priority: -- → P2
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/fa2218b2f4f1 Move various error-report-related structures and types into js/public/ErrorReport.h to minimize dependencies (and ultimately to make jsfriendapi.h not depend on jsapi.h). r=jandem
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fa2218b2f4f1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•