Closed Bug 1484421 Opened 6 years ago Closed 6 years ago

Move JSON-related functionality into js/public/JSON.h that isn't #include'd in jsapi.h

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

      No description provided.
Attached patch PatchSplinter Review
Attachment #9002182 - Flags: review?(jdemooij)
Comment on attachment 9002182 [details] [diff] [review]
Patch

Review of attachment 9002182 [details] [diff] [review]:
-----------------------------------------------------------------

We also have to add this header file to EXPORTS.js in moz.build

::: js/public/JSON.h
@@ +21,5 @@
> +class JSString;
> +
> +namespace JS { union Value; }
> +
> +using JSONWriteCallback = bool (*)(const char16_t* buf, uint32_t len, void* data);

I see what you did there :)
Attachment #9002182 - Flags: review?(jdemooij) → review+
Priority: -- → P2
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab5ac052f221
Move JSON-related functionality into js/public/JSON.h that isn't #include'd in jsapi.h.  r=jandem
https://hg.mozilla.org/mozilla-central/rev/ab5ac052f221
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: