1484434 - Port bug 1478813 - all builds busted with: ERROR: Cannot find cbindgen

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Jorg K (CEST = GMT+2)]

We need to port:
https://hg.mozilla.org/mozilla-central/rev/8fc7f2fb5ffc

Comment 1

[Jorg K (CEST = GMT+2)]

The trouble is, we don't have any of those files :-(

Best I can try is to add
  unset CBINDGEN
to mail/config/mozconfigs/common

Try builds didn't start earlier this morning, so no idea what will happen to this:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f2b75effed32953dbdc50b1b6679d8781807caf8

Comment 2

[Jorg K (CEST = GMT+2)]

Now the try jobs did start, so let's see.

Comment 3

[Jorg K (CEST = GMT+2)]

No success, so let's try adding
  CBINDGEN="${TOOLTOOL_DIR}/cbindgen/cbindgen"
instead.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9b491eeb60f7ada3e7a799092e6d846a9b7608bc

Comment 4

[Jorg K (CEST = GMT+2)]

That didn't work either, so I ran out of ideas.

Comment 5

[Jorg K (CEST = GMT+2)]

Well, maybe it helps adding it to the TC files:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c641232f95265f4cc979f8d9a71ecade6b8ab9bf

Comment 6

[Richard Marti (:Paenglab)]

You beat me. I saw m-c installed the cbindgen and c-c not. So this would be my proposal. :-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6d1f77df290e
Port bug 1478813: add cbindgen to TaskCluster files. rs=bustage-fix CLOSED TREE

Comment 8

[Jorg K (CEST = GMT+2)]

Let's assume that will work, sadly jobs don't start on try-comm-central, so not a comfortable situation to be in :-(

Comment 9

[Richard Marti (:Paenglab)]

Seems to work. Already some green "B".

Comment 10

[Jorg K (CEST = GMT+2)]

Tom, do these need to be in any particular order?

I added *-cbindgen before *-node, but I see now that M-C added it before *-sccache, or after *-node:
https://hg.mozilla.org/mozilla-central/rev/668856ac23b1#l10.48
https://hg.mozilla.org/mozilla-central/rev/668856ac23b1#l10.30

It's not in alphabetical order either:
     toolchains:
         - linux64-clang
         - linux64-gcc
         - linux64-rust
         - linux64-rust-size
+        - linux64-cbindgen
         - linux64-sccache
         - linux64-node

Comment 11

[Emilio Cobos Álvarez (:emilio)]

(In reply to Jorg K (GMT+2) from comment #10)
They don't need to be in any order.

Comment 12

[Jorg K (CEST = GMT+2)]

Tom told me in a PM (quote):
  I'd put it in alphabetical. It originally was, but then stuff got added out of order. The order doesn't matter, though.

I'll reorder it at the next opportunity.

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: 1484434-sort.patch

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b8f33483f6cf
Follow-up: Sort toolchains alphabetically. r=me