Closed
Bug 1484435
Opened 6 years ago
Closed 6 years ago
Simplify MacOS sidebar tree styling
Categories
(Firefox :: Theme, enhancement)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file, 3 obsolete files)
|
5.38 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9002192 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Further explanation: The 10.10+ tree styling (-moz-cellhighlighttext for selected, and HighlightText for selected, focus) is consistent with MacOS's -moz-appearance: -moz-mac-source-list-selection and -moz-mac-active-source-list-selection background colors, so we can simply remove the custom color rules for 10.10+. On the other hand, 10.9 has dark backgrounds -moz-mac-source-list-selection and -moz-mac-active-source-list-selection, so we need to set the color to white for both states.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Attachment #9002198 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9002192 -
Attachment is obsolete: true
Attachment #9002192 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Attachment #9002199 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9002198 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9002198 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #9002200 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9002199 -
Attachment is obsolete: true
Attachment #9002199 -
Flags: review?(dao+bmo)
|
||
Updated•6 years ago
|
Attachment #9002200 -
Flags: review?(dao+bmo) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0061cf77f918 Simplify MacOS sidebar tree styling. r=dao
Keywords: checkin-needed
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0061cf77f918
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•