Closed Bug 1484463 Opened 3 years ago Closed 3 years ago
Crash in java
.lang .Illegal State Exception: at org .mozilla .gecko .Gecko App Shell .set Screen Depth Override(Gecko App Shell .java)
46 bytes, text/x-phabricator-request
|Details | Review|
This bug was filed from the Socorro interface and is report bp-4de0448c-80a3-4f1b-a5a8-b265a0180818. ============================================================= java.lang.IllegalStateException at org.mozilla.gecko.GeckoAppShell.setScreenDepthOverride(GeckoAppShell.java:1053) at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method) at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:504) ============================================================= There is 1 crash in nightly 63 with buildid 20180818100303. In analyzing the backtrace, the regression may have been introduced by patch  to fix bug 1483420.  https://hg.mozilla.org/mozilla-central/rev?node=b439cdd35e49
It would seem that this call: https://dxr.mozilla.org/mozilla-central/source/widget/android/nsAppShell.cpp#586 Is happening too late. :jchen should I just remove the exception and just return as it used to do? I think the override needs to be set earlier to even work. My guess is this is crashing on people who have set the preference thinking it will improve performance?
Flags: needinfo?(rbarker) → needinfo?(nchen)
It was decided to just remove the setting. I'll post a patch shortly.
Comment on attachment 9002551 [details] Bug 1484463 - Remove GeckoAppShell.setScreenDepthOverride(). r=jchen Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9002551 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a13766399397 Remove GeckoAppShell.setScreenDepthOverride(). r=jchen
You need to log in before you can comment on or make changes to this bug.