1484463 - Crash in java.lang.IllegalStateException: at org.mozilla.gecko.GeckoAppShell.setScreenDepthOverride(GeckoAppShell.java)

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-4de0448c-80a3-4f1b-a5a8-b265a0180818.
=============================================================

java.lang.IllegalStateException
	at org.mozilla.gecko.GeckoAppShell.setScreenDepthOverride(GeckoAppShell.java:1053)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:504)

=============================================================

There is 1 crash in nightly 63 with buildid 20180818100303. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1483420.

[1] https://hg.mozilla.org/mozilla-central/rev?node=b439cdd35e49

Comment 1

[Randall Barker [:rbarker]]

It would seem that this call:

https://dxr.mozilla.org/mozilla-central/source/widget/android/nsAppShell.cpp#586

Is happening too late. :jchen should I just remove the exception and just return as it used to do? I think the override needs to be set earlier to even work. My guess is this is crashing on people who have set the preference thinking it will improve performance?

Comment 2

[Randall Barker [:rbarker]]

It was decided to just remove the setting. I'll post a patch shortly.

Comment 3

[Randall Barker [:rbarker]]

Attachment: Bug 1484463 - Remove GeckoAppShell.setScreenDepthOverride(). r=jchen

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9002551 [details]
Bug 1484463 - Remove GeckoAppShell.setScreenDepthOverride(). r=jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a13766399397
Remove GeckoAppShell.setScreenDepthOverride(). r=jchen

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a13766399397