1484473 - Recent m-c building dependent on a recent cbindgen package

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[:aceman]

https://hg.mozilla.org/mozilla-central/rev/8fc7f2fb5ffc added a dependency on the 'cbindgen' application. This is not very common so needs to be installed manually on Linux distros.
It seems e.g. version 0.4.3 from http://dl.fedoraproject.org/pub/fedora/linux/releases/28/Everything/x86_64/os/Packages/c/cbindgen-0.4.3-2.fc28.x86_64.rpm does not work.

The file <objdir>/layout/style/ServoStyleConsts.h is empty and there is an error output while building:
 cbindgen failed: error: Found argument '--lockfile' which wasn't expected, or isn't valid in this context

This however does not abort the build, it continues and then later fails on files using the mozilla::StyleDisplay symbols:

dist/include/nsIFrame.h:3921:19: error: ‘StyleDisplay’ in namespace ‘mozilla’ does not name a type:
inline mozilla::StyleDisplay GetDisplay() const;

Thanks to :emilio, running 'cargo install cbindgen' does install a never version (only for the particular user account) and that binary works to generate the file.

But this is not obvious and there should be some error message to guide the user about this :)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Add a cbindgen version check.

Comment 2

[u473386]

I'm having the same problem. I assume the above patch will not fix it.

https://bugzilla.mozilla.org/show_bug.cgi?id=1484485

Comment 3

[u473386]

(The above comment was on the wrong bug.)

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 9002251 [details]
Add a cbindgen version check.

Nathan Froyd [:froydnj] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9ba9a7a94d2
Add a cbindgen version check. r=firefox-build-system-reviewers,froydnj

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f9ba9a7a94d2

Comment 7

[:aceman]

Thanks, worked for me. It now forced me to update to 0.6.2 suggesting to install it via 'cargo'.