Closed Bug 1484473 Opened Last year Closed Last year

Recent m-c building dependent on a recent cbindgen package

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox63 fixed)

VERIFIED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: aceman, Assigned: emilio)

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/rev/8fc7f2fb5ffc added a dependency on the 'cbindgen' application. This is not very common so needs to be installed manually on Linux distros.
It seems e.g. version 0.4.3 from http://dl.fedoraproject.org/pub/fedora/linux/releases/28/Everything/x86_64/os/Packages/c/cbindgen-0.4.3-2.fc28.x86_64.rpm does not work.

The file <objdir>/layout/style/ServoStyleConsts.h is empty and there is an error output while building:
 cbindgen failed: error: Found argument '--lockfile' which wasn't expected, or isn't valid in this context

This however does not abort the build, it continues and then later fails on files using the mozilla::StyleDisplay symbols:

dist/include/nsIFrame.h:3921:19: error: ‘StyleDisplay’ in namespace ‘mozilla’ does not name a type:
inline mozilla::StyleDisplay GetDisplay() const;

Thanks to :emilio, running 'cargo install cbindgen' does install a never version (only for the particular user account) and that binary works to generate the file.

But this is not obvious and there should be some error message to guide the user about this :)
Component: Build Config → General
Flags: needinfo?(emilio)
Product: Toolkit → Firefox Build System
Assignee: nobody → emilio
Flags: needinfo?(emilio)
Comment on attachment 9002251 [details]
Add a cbindgen version check.

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9002251 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/f9ba9a7a94d2
Add a cbindgen version check. r=firefox-build-system-reviewers,froydnj
https://hg.mozilla.org/mozilla-central/rev/f9ba9a7a94d2
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Thanks, worked for me. It now forced me to update to 0.6.2 suggesting to install it via 'cargo'.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.