Closed
Bug 1484491
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 12561 - Add two selector tests for :nth-child selector with whitespace in the argument
Categories
(Core :: DOM: Core & HTML, enhancement, P4)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 12561 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12561 Details from upstream follow. Jason Killian <jason.killian@trialspark.com> wrote: > Add two selector tests for :nth-child selector with whitespace in the argument > > Over in [nwsapi](https://github.com/dperini/nwsapi) (which powers [jsdom](https://github.com/jsdom/jsdom)), we found [an issue](https://github.com/dperini/nwsapi/issues/20) where having space in an `nth-child` selector (e.g. `:nth-child(2n - 1)`) was causing the selector to fail. > > This PR adds two lines of tests to ensure that this scenario is covered. I verified that selectors with spaces like these two work in FF and Chrome and also that [the spec](https://drafts.csswg.org/selectors-3/#nth-child-pseudo) allows whitespace here.
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d39dec46aceadd4157f5e5b052ee56dad53b3ea
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4b3020cb163f01531a69143e307c11fdb9bd5f8
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=32d4bb5105b70d1e2230fe91e359d8d973cccb7e
Assignee | ||
Comment 4•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=335f8b37de4bbb1c4eb8e30424ea64aa00a61fba
Assignee | ||
Comment 5•6 years ago
|
||
Ran 4 tests and 5208 subtests OK : 4 PASS : 5208
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/32fec4d9b64b [wpt PR 12561] - Add two selector tests for :nth-child selector with whitespace in the argument, a=testonly
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/32fec4d9b64b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•