User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0 Build ID: 20180723085701 Steps to reproduce: Inspected code Actual results: Found dead code Expected results: Maybe remove the function CheckNewMail() from nsImapProtocol.cpp and its declaration and internal variable, m_checkForNewMailDownloadsHeaders, from nsImapProtocol.h. Using DXR, I don't see that this function is called anywhere and the variable it accesses and returns is never used other than intialized to true.
Severity: normal → trivial
Component: Untriaged → Networking: IMAP
Product: Thunderbird → MailNews Core
Remove it ;-)
The perfect bug to let me sleep well :) Tested with SeaMonkey 2.53 (56). Unused per dxr and I am still able to fetch mail via imap. Applies clean to comm-central.
Assignee: nobody → frgrahl
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9007640 - Flags: review?(jorgk)
Comment on attachment 9007640 [details] [diff] [review] 1484499-checknewmail.patch You beat Gene to it ;-)
Attachment #9007640 - Flags: review?(jorgk) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/6e094093b7db Remove unused nsImapProtocol::CheckNewMail(). r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.