Closed Bug 1484501 Opened 5 years ago Closed 5 years ago

extension.css uses :not(disabled) selector which is never going to match

Categories

(WebExtensions :: Frontend, defect)

Product:
WebExtensions
Component:
Frontend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file)

Bug 1484501 - Fix negated disabled selector in extension.css; r=bwinton
46 bytes, text/x-phabricator-request
bwinton
: review+
Details | Review 
https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/browser/components/extensions/extension.css#325-326

I'm pretty sure this wants to be :not(:disabled)

(I came across this because I was wondering why hover styles were applying on my disabled form control.)
Summary: extensions.css uses :not(disabled) when it probably means :not(:disabled) → extension.css uses :not(disabled) when it probably means :not(:disabled)
Looking at that file more closely, it seems we actually set a 'disabled' class and match on that. I'm not sure why we do that instead of using `:disabled` but clearly for consistency the selectors in question should be matching on that.
Summary: extension.css uses :not(disabled) when it probably means :not(:disabled) → extension.css uses :not(disabled) selector which is never going to match
Everywhere else in this file we match on .disabled or :not(.disabled) but in two
instances we have :not(disabled). That's never going to match since it's already
combined with an `input` or `textarea` type selector (and there's no <disabled>
element).
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment on attachment 9002338 [details]
Bug 1484501 - Fix negated disabled selector in extension.css; r=bwinton

Blake Winton (:bwinton) (:☕️) has approved the revision.
Attachment #9002338 - Flags: review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/feaff184f775
Fix negated disabled selector in extension.css; r=bwinton
See Also: → 1484911
https://hg.mozilla.org/mozilla-central/rev/feaff184f775
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(bbirtles)
(In reply to CosminB from comment #6)
> Is manual testing required on this bug? If yes, please provide some STR and
> the proper extension(if required) or set the “qe-verify -“ flag.
> 
> Thanks!

No. The work done in this bug was superseded by bug 1484911.
Flags: needinfo?(bbirtles)
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.