1484512 - Split up places.css and only load relevant parts of it

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Right now, places.css is loaded on:

- browser/base/content/browser.xul
- browser/components/places/content/bookmarkProperties.xul
- browser/components/places/content/bookmarksSidebar.xul
- browser/components/places/content/historySidebar.xul
- browser/components/places/content/places.xul
- browser/components/preferences/selectBookmark.xul

Most of these places (pun unintended) only need the tree-icons.css and the content CSS file.

Here's my proposal:
- Rename tree-icons.inc.css to tree-icons.css and load it on all the files above. Also remove the include inside places.css
- Rename skin/places.css to sidebar.css and load it only in bookmarksSidebar.xul and historySidebar.xul
- Potentially do some more cleanup

Comment 1

[Tim Nguyen :ntim]

Attachment: Split up places.css and only load relevant parts of it

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 9002271 [details] [diff] [review]
Split up places.css and only load relevant parts of it

>--- a/browser/themes/shared/places/tree-icons.inc.css
>+++ b/browser/themes/shared/places/tree-icons.css
>@@ -98,11 +98,6 @@ treechildren::-moz-tree-cell-text(title,
>   color: HighlightText;
> }
> 
>-treechildren::-moz-tree-twisty(title, separator) {
>-  -moz-appearance: none;
>-  padding: 0;
>-}
>-

What's this change about?

Comment 3

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [::dao] from comment #2)
> Comment on attachment 9002271 [details] [diff] [review]
> Split up places.css and only load relevant parts of it
> 
> >--- a/browser/themes/shared/places/tree-icons.inc.css
> >+++ b/browser/themes/shared/places/tree-icons.css
> >@@ -98,11 +98,6 @@ treechildren::-moz-tree-cell-text(title,
> >   color: HighlightText;
> > }
> > 
> >-treechildren::-moz-tree-twisty(title, separator) {
> >-  -moz-appearance: none;
> >-  padding: 0;
> >-}
> >-
> 
> What's this change about?

It didn't seem to have any effect, but I can restore it if needed.

Comment 4

[Dão Gottwald [:dao]]

And the common.inc.css changes?

Comment 5

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [::dao] from comment #4)
> And the common.inc.css changes?

There was a bug with the tree twisties not matching the current color when the row was selected.

I'm happy to move that fix to a different bug if needed.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen :ntim from comment #5)
> I'm happy to move that fix to a different bug if needed.

Yeah, please do.

Comment 7

[Tim Nguyen :ntim]

Attachment: Split up places.css and only load relevant parts of it

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/973b58266e44
Split up places.css and only load relevant parts of it. r=dao

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/973b58266e44