Closed Bug 1484512 Opened Last year Closed Last year

Split up places.css and only load relevant parts of it

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

(Whiteboard: [ntim-intern-project])

Attachments

(1 file, 1 obsolete file)

Right now, places.css is loaded on:

- browser/base/content/browser.xul
- browser/components/places/content/bookmarkProperties.xul
- browser/components/places/content/bookmarksSidebar.xul
- browser/components/places/content/historySidebar.xul
- browser/components/places/content/places.xul
- browser/components/preferences/selectBookmark.xul

Most of these places (pun unintended) only need the tree-icons.css and the content CSS file.

Here's my proposal:
- Rename tree-icons.inc.css to tree-icons.css and load it on all the files above. Also remove the include inside places.css
- Rename skin/places.css to sidebar.css and load it only in bookmarksSidebar.xul and historySidebar.xul
- Potentially do some more cleanup
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #9002271 - Flags: review?(dao+bmo)
Comment on attachment 9002271 [details] [diff] [review]
Split up places.css and only load relevant parts of it

>--- a/browser/themes/shared/places/tree-icons.inc.css
>+++ b/browser/themes/shared/places/tree-icons.css
>@@ -98,11 +98,6 @@ treechildren::-moz-tree-cell-text(title,
>   color: HighlightText;
> }
> 
>-treechildren::-moz-tree-twisty(title, separator) {
>-  -moz-appearance: none;
>-  padding: 0;
>-}
>-

What's this change about?
(In reply to Dão Gottwald [::dao] from comment #2)
> Comment on attachment 9002271 [details] [diff] [review]
> Split up places.css and only load relevant parts of it
> 
> >--- a/browser/themes/shared/places/tree-icons.inc.css
> >+++ b/browser/themes/shared/places/tree-icons.css
> >@@ -98,11 +98,6 @@ treechildren::-moz-tree-cell-text(title,
> >   color: HighlightText;
> > }
> > 
> >-treechildren::-moz-tree-twisty(title, separator) {
> >-  -moz-appearance: none;
> >-  padding: 0;
> >-}
> >-
> 
> What's this change about?

It didn't seem to have any effect, but I can restore it if needed.
And the common.inc.css changes?
(In reply to Dão Gottwald [::dao] from comment #4)
> And the common.inc.css changes?

There was a bug with the tree twisties not matching the current color when the row was selected.

I'm happy to move that fix to a different bug if needed.
(In reply to Tim Nguyen :ntim from comment #5)
> I'm happy to move that fix to a different bug if needed.

Yeah, please do.
Flags: needinfo?(ntim.bugs)
Attachment #9002271 - Flags: review?(dao+bmo)
Attachment #9002271 - Attachment is obsolete: true
Flags: needinfo?(ntim.bugs)
Attachment #9002704 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/973b58266e44
Split up places.css and only load relevant parts of it. r=dao
Whiteboard: [ntim-intern-project]
https://hg.mozilla.org/mozilla-central/rev/973b58266e44
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Blocks: 1418602
You need to log in before you can comment on or make changes to this bug.