1484534 - SSL error page on Fennec doesn't have details

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Fennec nightly, go to https://www.babyktan.com/kangaroo - this brings up an "untrusted connection" error page. Clicking on "technical details" provides no details, but I would expect it to. The section is just empty.

Comment 1

[Johann Hofmann [:johannh]]

Is this a regression in Nightly?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

On beta the page loads. So it's some sort of regression, probably exposed by tighter restrictions on what classes of security problems are blocked.

Comment 3

[Jan Henning [:JanH]]

It's not generally broken, though, because various things on https://badssl.com still show a detailed error message.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

This is a change in behavior, not a simple regression. It is from the distrust https://blog.nightly.mozilla.org/2018/08/14/symantec-distrust-in-firefox-nightly-63/

I expect that there are some strings or methods that are part of the desktop error pages that were not copied to the mobile error pages. NI to one of the leads on the distrust.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Looks like this was a result of bug 1475647: E/GeckoConsole(19158): [JavaScript Error: "ReferenceError: securityInfo is not defined" {file: "chrome://browser/content/content.js" line: 188}]

Franziskus, do you have time to take care of this? It looks like we just need to pass `securityInfo` (or really just `securityInfo.errorCode`) to `_setTechDetailsMsgPart1`.

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

D'oh - I meant bug 1415279.

Comment 7

[Franziskus Kiefer [:franziskus]]

Attachment: Bug 1484534 - fix Android error page technical details

Looks like I forgot to pass in `securityInfo`. I'm surprised noone (no test;) noticed this earlier.
Not sure who's best to review this. But it's not too much code anyway :)

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 9002683 [details]
Bug 1484534 - fix Android error page technical details

Johann Hofmann [:johannh] has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0da740d9db4
fix Android error page technical details r=johannh

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f0da740d9db4