Closed Bug 1484534 Opened Last year Closed Last year

SSL error page on Fennec doesn't have details

Categories

(Core :: Security: PSM, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox62 --- unaffected
firefox63 + fixed

People

(Reporter: kats, Assigned: franziskus)

References

Details

Attachments

(1 file)

Fennec nightly, go to https://www.babyktan.com/kangaroo - this brings up an "untrusted connection" error page. Clicking on "technical details" provides no details, but I would expect it to. The section is just empty.
Product: Firefox → Firefox for Android
Is this a regression in Nightly?
Flags: needinfo?(kats)
On beta the page loads. So it's some sort of regression, probably exposed by tighter restrictions on what classes of security problems are blocked.
Flags: needinfo?(kats)
It's not generally broken, though, because various things on https://badssl.com still show a detailed error message.
This is a change in behavior, not a simple regression. It is from the distrust https://blog.nightly.mozilla.org/2018/08/14/symantec-distrust-in-firefox-nightly-63/

I expect that there are some strings or methods that are part of the desktop error pages that were not copied to the mobile error pages. NI to one of the leads on the distrust.
Blocks: 1460062
Flags: needinfo?(dkeeler)
OS: Unspecified → Android
Hardware: Unspecified → All
Looks like this was a result of bug 1475647: E/GeckoConsole(19158): [JavaScript Error: "ReferenceError: securityInfo is not defined" {file: "chrome://browser/content/content.js" line: 188}]

Franziskus, do you have time to take care of this? It looks like we just need to pass `securityInfo` (or really just `securityInfo.errorCode`) to `_setTechDetailsMsgPart1`.
Blocks: 1475647
Component: General → Security: PSM
Flags: needinfo?(dkeeler) → needinfo?(franziskuskiefer)
Product: Firefox for Android → Core
Looks like I forgot to pass in `securityInfo`. I'm surprised noone (no test;) noticed this earlier.
Not sure who's best to review this. But it's not too much code anyway :)
Flags: needinfo?(franziskuskiefer)
Comment on attachment 9002683 [details]
Bug 1484534 - fix Android error page technical details

Johann Hofmann [:johannh] has approved the revision.
Attachment #9002683 - Flags: review+
Pushed by franziskuskiefer@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f0da740d9db4
fix Android error page technical details r=johannh
https://hg.mozilla.org/mozilla-central/rev/f0da740d9db4
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → franziskuskiefer
You need to log in before you can comment on or make changes to this bug.