Closed
Bug 1484571
Opened 6 years ago
Closed 6 years ago
get rid of NormalDeclarationIterator
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
We can make PropertyDeclarationBlock::normal_declaration_iter return `impl DoubleEndedIterator` to remove most needs for NormalDeclarationIterator. There is also a NormalDeclarationIterator field in AnimationValueIterator, so I've made that a DeclarationImportanceIterator and manually skip important declarations. (I feel like there should be some way to make animation_value_iter() return `impl Iterator` too, but I couldn't figure out how to deal with the different lifetimes of that function's parameters.)
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9002345 [details] Bug 1484571 - Replace NormalDeclarationIterator return type with `impl Trait`. r?xidorn Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9002345 -
Flags: review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a592b4286d6f Replace NormalDeclarationIterator return type with `impl Trait`. r=xidorn
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a592b4286d6f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
Assignee: nobody → cam
You need to log in
before you can comment on or make changes to this bug.
Description
•