Closed Bug 1484571 Opened 2 years ago Closed 2 years ago

get rid of NormalDeclarationIterator

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

We can make PropertyDeclarationBlock::normal_declaration_iter return `impl DoubleEndedIterator` to remove most needs for NormalDeclarationIterator.  There is also a NormalDeclarationIterator field in AnimationValueIterator, so I've made that a DeclarationImportanceIterator and manually skip important declarations.

(I feel like there should be some way to make animation_value_iter() return `impl Iterator` too, but I couldn't figure out how to deal with the different lifetimes of that function's parameters.)
Comment on attachment 9002345 [details]
Bug 1484571 - Replace NormalDeclarationIterator return type with `impl Trait`. r?xidorn

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9002345 - Flags: review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a592b4286d6f
Replace NormalDeclarationIterator return type with `impl Trait`. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/a592b4286d6f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → cam
You need to log in before you can comment on or make changes to this bug.