1484571 - get rid of NormalDeclarationIterator

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

We can make PropertyDeclarationBlock::normal_declaration_iter return `impl DoubleEndedIterator` to remove most needs for NormalDeclarationIterator.  There is also a NormalDeclarationIterator field in AnimationValueIterator, so I've made that a DeclarationImportanceIterator and manually skip important declarations.

(I feel like there should be some way to make animation_value_iter() return `impl Iterator` too, but I couldn't figure out how to deal with the different lifetimes of that function's parameters.)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1484571 - Replace NormalDeclarationIterator return type with `impl Trait`. r?xidorn

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 9002345 [details]
Bug 1484571 - Replace NormalDeclarationIterator return type with `impl Trait`. r?xidorn

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a592b4286d6f
Replace NormalDeclarationIterator return type with `impl Trait`. r=xidorn

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a592b4286d6f